✨ Collect WebSocket resource events#4718
Draft
bdibon wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Bundles Sizes Evolution
|
f9f774b to
f67e33e
Compare
ec073a8 to
98e75c8
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
f67e33e to
adaf9f3
Compare
98e75c8 to
1afcc3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
Collect WebSocket connections and report them as RUM resource events, aggregating connection-level metrics.
Changes
webSocketCollection, which aggregates per-connection metrics fromwebSocketObservableand emits aWEBSOCKET_COMPLETEDlifecycle event.resourceCollection: assemble a websocketRumResourceEventand skip websocket entries from the Resource Timing observer; addmatchRequestResourceEntry.startWebSocketCollectionintostartRum, gated bytrackWebSockets+ theTRACK_WEB_SOCKETSflag.Access-Control-Allow-Origin: *to the dev server to support local cross-origin WebSocket testing.Test instructions
yarn test:unit --spec packages/rum-core/src/domain/webSocketCollection.spec.tsyarn test:unit --spec packages/rum-core/src/domain/resource/resourceCollection.spec.tsChecklist