-
Notifications
You must be signed in to change notification settings - Fork 3.5k
fix: Page opacity inconsistance in offline #78422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@truph01 Could you resolve conflict in the mean time? Ty |
|
little bump @truph01 |
|
@hungvu193 I just merged main and fixed conflicts. |
You might need to update your submodule version too |
@hungvu193 Ah, I missed it. Just updated. Thanks! |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-12-30.at.17.58.00.movAndroid: mWeb ChromeScreen.Recording.2025-12-30.at.17.43.39.moviOS: HybridAppios.moviOS: mWeb SafarimSafari.movMacOS: Chrome / SafariChrome.mov |
chuckdries
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/chuckdries in version: 9.2.90-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.90-2 🚀
|
Explanation of Change
Currently, when an expense is created, we do not automatically create its associated transaction thread. The thread is only created when the user opens the expense for the first time. Reference
As a result, if the user opens the expense for the first time while offline, the thread is rendered with 50% opacity, which is misleading from the user's perspective even though the transaction was originally created while online.
This PR fixes that by ensuring the transaction thread is rendered with 100% opacity, accurately reflecting its true state.
Fixed Issues
$ #76402
PROPOSAL: #76402 (comment)
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-12-24.at.16.04.10.mov
Android: mWeb Chrome
Screen.Recording.2025-12-24.at.15.59.36.mov
iOS: Native
Screen.Recording.2025-12-24.at.16.05.22.mov
iOS: mWeb Safari
Screen.Recording.2025-12-24.at.15.57.29.mov
MacOS: Chrome / Safari
Screen.Recording.2025-12-24.at.15.42.54.mov