feat: choose environment administrators on environment creation#7610
feat: choose environment administrators on environment creation#7610kyle-ssg wants to merge 2 commits into
Conversation
…ment creation Lets the creator assign other users and roles as environment administrators directly from the Create Environment page. Adds dedicated RTK endpoints for environment user and role permissions, and assigns selections on save with a partial-failure toast. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
github-actions
Bot
added
the
front-end
Docker builds report
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to assign environment administrators (both users and roles) during the creation of a new environment. It adds the necessary API endpoints, hooks, request types, and UI components to support this feature. A critical bug was identified in CreateEnvironmentPage.tsx where a stale closure on organisationId inside assignEnvironmentAdmins could cause API requests to fail if the organization ID resolves after the component mounts. It is recommended to read the latest organization ID directly from AccountStore inside the function.
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
|
Visual Regression19 screenshots compared. See report for details. |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
github-actions
Bot
added
feature
1 participant
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Lets the creator assign other users and roles as environment administrators directly from the Create Environment page, rather than having to open Environment Settings → Permissions afterwards. Selections are applied on save; a partial-failure toast points to Environment Settings → Permissions for retry.
How did you test this code?