[Fix] 0047065 UI: Lightbox carousel nav – use data-target and type="b… #11021
+5
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BettyFromHH
added
the
css/html
thibsy
requested changes
Feb 3, 2026
Contributor
There was a problem hiding this comment.
Hi @fhelfer,
Thx a lot for the fix.
Please answer the following questions:
-
href: I think we only needed to provide this attribute because a link has been used previously. Since you did not change any JavaScript, I assume this attribute became obsolete and can be removed entirely. Am I right?
Please implement these changes:
- Rebase: I have overlooked this PR when merging #11037 this morning. Would you be so kind and rebase your fix onto the latest version? Your proposal is actually more coherent and addresses a different issue at the same time.
Kind regards,
@thibsy (as UI coordinator)
fhelfer
force-pushed
the
ui/mantis/47065
branch
from
184594e to
79d5a07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error: Attribute “href” not allowed on element “button” at this point
https://mantis.ilias.de/view.php?id=47065
href on is invalid. Replace with data-target for carousel
target; add type="button" and remove redundant role="button".
Update LightboxTest.
- Validator: href auf
im Lightbox-Carousel ungültig.Lösung