Skip to content

[Fix] 0047065 UI: Lightbox carousel nav – use data-target and type="b… #11021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fhelfer wants to merge 2 commits into
base: release_11
Choose a base branch
from
+5 −7
Open

[Fix] 0047065 UI: Lightbox carousel nav – use data-target and type="b… #11021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6aa638a
[Fix] 0047065 UI: Lightbox carousel nav – use data-target and type="b…
fhelfer Jan 30, 2026
79d5a07
[Fix] 0047065 UI: Lightbox carousel remove data-target
fhelfer Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions components/ILIAS/UI/src/Implementation/Component/Modal/Renderer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,11 +262,9 @@ protected function renderLightbox(Component\Modal\Lightbox $modal, RendererInter
$first = false;
}
if (count($pages) > 1) {
$tpl->setCurrentBlock('controls');
$tpl->setVariable('ID_CAROUSEL3', $id_carousel);
$tpl->touchBlock('controls');
$tpl->parseCurrentBlock();
}
$tpl->setVariable('ID_CAROUSEL4', $id_carousel);
return $tpl->get();
}

Expand Down
4 changes: 2 additions & 2 deletions components/ILIAS/UI/src/templates/default/Modal/tpl.lightbox.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ <h1 class="modal-title">{TITLE}</h1>
</div>

<!-- BEGIN controls -->
<button class="left carousel-control btn-link" href="#{ID_CAROUSEL3}" role="button" type="button" data-slide="prev">
<button class="left carousel-control btn-link" type="button" data-slide="prev">
<span class="glyphicon glyphicon-chevron-left" aria-hidden="true"></span>
<span class="sr-only">Previous</span>
</button>
<button class="right carousel-control btn-link" href="#{ID_CAROUSEL3}" role="button" type="button" data-slide="next">
<button class="right carousel-control btn-link" type="button" data-slide="next">
<span class="glyphicon glyphicon-chevron-right" aria-hidden="true"></span>
<span class="sr-only">Next</span>
</button>
Expand Down
4 changes: 2 additions & 2 deletions components/ILIAS/UI/tests/Component/Modal/LightboxTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,11 +183,11 @@ protected static function getExpectedMixedPagesHTML(): string
</div>
</div>

<button class="left carousel-control btn-link" href="#id_1_carousel" role="button" type="button" data-slide="prev">
<button class="left carousel-control btn-link" type="button" data-slide="prev">
<span class="glyphicon glyphicon-chevron-left" aria-hidden="true"></span>
<span class="sr-only">Previous</span>
</button>
<button class="right carousel-control btn-link" href="#id_1_carousel" role="button" type="button" data-slide="next">
<button class="right carousel-control btn-link" type="button" data-slide="next">
<span class="glyphicon glyphicon-chevron-right" aria-hidden="true"></span>
<span class="sr-only">Next</span>
</button>
Expand Down