Remove reflectors from orchestratord#35806
Merged
alex-hunt-materialize merged 2 commits intoMaterializeInc:mainfrom Mar 31, 2026
Merged
Conversation
Contributor
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
Contributor
|
You can reenable the test by removing the |
6e6ba28 to
ba7f1de
Compare
doy-materialize
approved these changes
Mar 31, 2026
Remove reflectors from orchestratord. These introduced race conditions between the reconciliation's watcher and the reflector store's watcher, and causes very subtle bugs. If we just get the objects each time, we don't need the reflector.
59971c1 to
ac6afea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove reflectors from orchestratord.
These introduced race conditions between the reconciliation's watcher and the reflector store's watcher, and causes very subtle bugs. If we just get the objects each time, we don't need the reflector.
Motivation
Might fix https://github.com/MaterializeInc/database-issues/issues/11225
Verification
Orchestratord nightly tests.