Skip to content

Remove reflectors from orchestratord#35806

Merged
alex-hunt-materialize merged 2 commits intoMaterializeInc:mainfrom
alex-hunt-materialize:remove_reflectors_from_orchestratord
Mar 31, 2026
Merged

Remove reflectors from orchestratord#35806
alex-hunt-materialize merged 2 commits intoMaterializeInc:mainfrom
alex-hunt-materialize:remove_reflectors_from_orchestratord

Conversation

@alex-hunt-materialize
Copy link
Copy Markdown
Contributor

Remove reflectors from orchestratord.

These introduced race conditions between the reconciliation's watcher and the reflector store's watcher, and causes very subtle bugs. If we just get the objects each time, we don't need the reflector.

Motivation

Might fix https://github.com/MaterializeInc/database-issues/issues/11225

Verification

Orchestratord nightly tests.

@github-actions
Copy link
Copy Markdown
Contributor

Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone.

PR title guidelines

  • Use imperative mood: "Fix X" not "Fixed X" or "Fixes X"
  • Be specific: "Fix panic in catalog sync when controller restarts" not "Fix bug" or "Update catalog code"
  • Prefix with area if helpful: compute: , storage: , adapter: , sql:

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

@def-
Copy link
Copy Markdown
Contributor

def- commented Mar 31, 2026

You can reenable the test by removing the skip: "database-issues#11225" in ci/nightly/pipeline.template.yml

Remove reflectors from orchestratord.

These introduced race conditions between the reconciliation's watcher
and the reflector store's watcher, and causes very subtle bugs.
If we just get the objects each time, we don't need the reflector.
@alex-hunt-materialize alex-hunt-materialize force-pushed the remove_reflectors_from_orchestratord branch from 59971c1 to ac6afea Compare March 31, 2026 16:18
@alex-hunt-materialize alex-hunt-materialize marked this pull request as ready for review March 31, 2026 16:47
@alex-hunt-materialize alex-hunt-materialize requested a review from a team as a code owner March 31, 2026 16:47
@alex-hunt-materialize alex-hunt-materialize merged commit 927cd62 into MaterializeInc:main Mar 31, 2026
129 checks passed
@alex-hunt-materialize alex-hunt-materialize deleted the remove_reflectors_from_orchestratord branch March 31, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants