Skip to content

feat: add feature_id and batch_id to Unified SwapBridge events #8964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
micaelae wants to merge 16 commits into
base: main
Choose a base branch
from
Open

feat: add feature_id and batch_id to Unified SwapBridge events #8964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
87754ed
chore: update featureId type
micaelae Jun 3, 2026
0d116b5
chore: add batch_id to controller metric types
micaelae Jun 3, 2026
3d8e11b
chore: export generateBatchId
micaelae Jun 3, 2026
52fb826
feat: add batch_id property to status events
micaelae Jun 3, 2026
7dbe889
feat: require feature_id property
micaelae Jun 3, 2026
2d48f12
feat: add feature_id to all bridge-controller events
micaelae Jun 3, 2026
09ba94e
chore: populate feature_id and batch_id
micaelae Jun 3, 2026
326b079
refactor: comments and move batch-sell-strategy tradeMeta step
micaelae Jun 3, 2026
4ddac53
fix: update transaction-pay fetchQuotes params
micaelae Jun 3, 2026
3368993
Merge branch 'main' into swaps4468-feature-id-batch-id
micaelae Jun 3, 2026
51dc34e
fix: lint and tests
micaelae Jun 3, 2026
b8cb4ea
fix: test
micaelae Jun 3, 2026
6051dd1
fix: test
micaelae Jun 3, 2026
1b5dc76
chore: require batch_id
micaelae Jun 3, 2026
5c9a8ea
chore: changelog
micaelae Jun 3, 2026
f5ff6e5
Merge branch 'main' into swaps4468-feature-id-batch-id
micaelae Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/bridge-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,19 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Added

- Add `QUICK_BUY_FOLLOW_TRADING`, `QUICK_BUY_TOKEN_DETAILS`, `BATCH_SELL` and `UNIFIED_SWAP_BRIDGE` to FeatureId enum ([#8964](https://github.com/MetaMask/core/pull/8964))
- Update metrics schema with `batch_id` property ([#8964](https://github.com/MetaMask/core/pull/8964))

### Changed

- **BREAKING**: require all events to have the `feature_id` property ([#8964](https://github.com/MetaMask/core/pull/8964))
- **BREAKING**: require FeatureId argument when calling `BridgeController:fetchQuotes` ([#8964](https://github.com/MetaMask/core/pull/8964))
- Rename FeatureIds to match segment property conventions ([#8964](https://github.com/MetaMask/core/pull/8964))
- `quickBuy` to `quick_buy_follow_trading` and `quick_buy_token_details`
- `dappSwap` to `dapp_swap`

## [73.2.1]

### Changed
Expand Down
5 changes: 5 additions & 0 deletions packages/bridge-controller/src/__snapshots__/bridge-controller.sse.batch.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ exports[`BridgeController BatchSell (multiple quote requests) SSE fetch quotes s
"Unified SwapBridge Input Changed",
{
"action_type": "swapbridge-v1",
"feature_id": "batch_sell",
"input": "chain_source",
"input_value": "eip155:10",
"location": "Main View",
Expand All @@ -75,6 +76,7 @@ exports[`BridgeController BatchSell (multiple quote requests) SSE fetch quotes s
"Unified SwapBridge Input Changed",
{
"action_type": "swapbridge-v1",
"feature_id": "batch_sell",
"input": "chain_destination",
"input_value": "eip155:137",
"location": "Main View",
Expand All @@ -84,6 +86,7 @@ exports[`BridgeController BatchSell (multiple quote requests) SSE fetch quotes s
"Unified SwapBridge Input Changed",
{
"action_type": "swapbridge-v1",
"feature_id": "batch_sell",
"input": "token_destination",
"input_value": "eip155:137/erc20:0x3c499c542cEF5E3811e1192ce70d8cC03d5c3359",
"location": "Main View",
Expand All @@ -93,6 +96,7 @@ exports[`BridgeController BatchSell (multiple quote requests) SSE fetch quotes s
"Unified SwapBridge Input Changed",
{
"action_type": "swapbridge-v1",
"feature_id": "batch_sell",
"input": "slippage",
"input_value": 0.5,
"location": "Main View",
Expand All @@ -106,6 +110,7 @@ exports[`BridgeController BatchSell (multiple quote requests) SSE fetch quotes s
"chain_id_destination": "eip155:137",
"chain_id_source": "eip155:10",
"custom_slippage": true,
"feature_id": "batch_sell",
"has_sufficient_funds": true,
"is_hardware_wallet": false,
"location": "Main View",
Expand Down
18 changes: 18 additions & 0 deletions packages/bridge-controller/src/__snapshots__/bridge-controller.sse.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ exports[`BridgeController SSE should publish validation failures 4`] = `
"lifi|trade.inputsToSign",
"lifi|trade.raw_data_hex",
],
"feature_id": "unified_swap_bridge",
"location": "Main View",
"refresh_count": 1,
"token_address_destination": "solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp/token:123d1",
Expand All @@ -36,6 +37,7 @@ exports[`BridgeController SSE should publish validation failures 4`] = `
"failures": [
"unknown|unknown",
],
"feature_id": "unified_swap_bridge",
"location": "Main View",
"refresh_count": 1,
"token_address_destination": "solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp/token:123d1",
Expand All @@ -52,6 +54,7 @@ exports[`BridgeController SSE should publish validation failures 4`] = `
"failures": [
"unknown|quote",
],
"feature_id": "unified_swap_bridge",
"location": "Main View",
"refresh_count": 1,
"token_address_destination": "solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp/token:123d1",
Expand All @@ -71,6 +74,7 @@ exports[`BridgeController SSE should replace all stale quotes after a refresh an
"chain_id_destination": "solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp",
"chain_id_source": "eip155:1",
"custom_slippage": true,
"feature_id": "unified_swap_bridge",
"has_sufficient_funds": true,
"is_hardware_wallet": false,
"location": "Main View",
Expand Down Expand Up @@ -99,6 +103,7 @@ exports[`BridgeController SSE should reset and refetch quotes after quote reques
"chain_id_destination": "solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp",
"chain_id_source": "eip155:1",
"custom_slippage": true,
"feature_id": "unified_swap_bridge",
"has_sufficient_funds": false,
"is_hardware_wallet": false,
"location": "Main View",
Expand Down Expand Up @@ -127,6 +132,7 @@ exports[`BridgeController SSE should reset quotes list if quote refresh fails 2`
"chain_id_destination": "solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp",
"chain_id_source": "eip155:1",
"custom_slippage": true,
"feature_id": "unified_swap_bridge",
"has_sufficient_funds": true,
"is_hardware_wallet": false,
"location": "Main View",
Expand All @@ -152,6 +158,7 @@ exports[`BridgeController SSE should reset quotes list if quote refresh fails 2`
"chain_id_source": "eip155:1",
"custom_slippage": true,
"error_message": "Network error",
"feature_id": "unified_swap_bridge",
"has_sufficient_funds": true,
"is_hardware_wallet": false,
"location": "Main View",
Expand Down Expand Up @@ -213,6 +220,7 @@ exports[`BridgeController SSE should rethrow error from server 3`] = `
"Unified SwapBridge Input Changed",
{
"action_type": "swapbridge-v1",
"feature_id": "unified_swap_bridge",
"input": "chain_source",
"input_value": "eip155:1",
"location": "Main View",
Expand All @@ -222,6 +230,7 @@ exports[`BridgeController SSE should rethrow error from server 3`] = `
"Unified SwapBridge Input Changed",
{
"action_type": "swapbridge-v1",
"feature_id": "unified_swap_bridge",
"input": "chain_destination",
"input_value": "solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp",
"location": "Main View",
Expand All @@ -231,6 +240,7 @@ exports[`BridgeController SSE should rethrow error from server 3`] = `
"Unified SwapBridge Input Changed",
{
"action_type": "swapbridge-v1",
"feature_id": "unified_swap_bridge",
"input": "token_destination",
"input_value": "solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp/token:123d1",
"location": "Main View",
Expand All @@ -240,6 +250,7 @@ exports[`BridgeController SSE should rethrow error from server 3`] = `
"Unified SwapBridge Input Changed",
{
"action_type": "swapbridge-v1",
"feature_id": "unified_swap_bridge",
"input": "slippage",
"input_value": 0.5,
"location": "Main View",
Expand All @@ -253,6 +264,7 @@ exports[`BridgeController SSE should rethrow error from server 3`] = `
"chain_id_destination": "solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp",
"chain_id_source": "eip155:1",
"custom_slippage": true,
"feature_id": "unified_swap_bridge",
"has_sufficient_funds": true,
"is_hardware_wallet": false,
"location": "Main View",
Expand All @@ -278,6 +290,7 @@ exports[`BridgeController SSE should rethrow error from server 3`] = `
"chain_id_source": "eip155:1",
"custom_slippage": true,
"error_message": "Bridge-api error: timeout from server",
"feature_id": "unified_swap_bridge",
"has_sufficient_funds": true,
"is_hardware_wallet": false,
"location": "Main View",
Expand Down Expand Up @@ -339,6 +352,7 @@ exports[`BridgeController SSE should trigger quote polling if request is valid 2
"Unified SwapBridge Input Changed",
{
"action_type": "swapbridge-v1",
"feature_id": "unified_swap_bridge",
"input": "chain_source",
"input_value": "eip155:1",
"location": "Main View",
Expand All @@ -348,6 +362,7 @@ exports[`BridgeController SSE should trigger quote polling if request is valid 2
"Unified SwapBridge Input Changed",
{
"action_type": "swapbridge-v1",
"feature_id": "unified_swap_bridge",
"input": "chain_destination",
"input_value": "solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp",
"location": "Main View",
Expand All @@ -357,6 +372,7 @@ exports[`BridgeController SSE should trigger quote polling if request is valid 2
"Unified SwapBridge Input Changed",
{
"action_type": "swapbridge-v1",
"feature_id": "unified_swap_bridge",
"input": "token_destination",
"input_value": "solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp/token:123d1",
"location": "Main View",
Expand All @@ -366,6 +382,7 @@ exports[`BridgeController SSE should trigger quote polling if request is valid 2
"Unified SwapBridge Input Changed",
{
"action_type": "swapbridge-v1",
"feature_id": "unified_swap_bridge",
"input": "slippage",
"input_value": 0.5,
"location": "Main View",
Expand All @@ -379,6 +396,7 @@ exports[`BridgeController SSE should trigger quote polling if request is valid 2
"chain_id_destination": "solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp",
"chain_id_source": "eip155:1",
"custom_slippage": true,
"feature_id": "unified_swap_bridge",
"has_sufficient_funds": true,
"is_hardware_wallet": false,
"location": "Main View",
Expand Down
Loading
Loading