Add upsert lambda #280
Open
Add upsert lambda #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francisco-videira-nhs
force-pushed
the
feature/CCM-12997
branch
from
8c4f7c3 to
8a74c03
Compare
sidnhs
reviewed
Dec 15, 2025
infrastructure/terraform/components/api/module_lambda_upsert_letter.tf
Outdated
Show resolved
Hide resolved
m-houston
reviewed
Dec 15, 2025
m-houston
reviewed
Dec 15, 2025
m-houston
reviewed
Dec 19, 2025
m-houston
previously approved these changes
Dec 19, 2025
Vlasis-Perdikidis
previously approved these changes
Dec 23, 2025
| }; | ||
|
|
||
| function createDocumentClient(): DynamoDBDocumentClient { | ||
| const ddbClient = new DynamoDBClient({}); |
There was a problem hiding this comment.
should the region be passed in during creation?
Which region is used by default if you omit it?
10 tasks
masl2
dismissed stale reviews from Vlasis-Perdikidis and m-houston
via
547f6b1
* swap partition and sort for letters * store changes and source, subject, billingref * unsafe marker * rename correctly
10 tasks
masl2
approved these changes
Dec 24, 2025
Comment on lines
+217
to
+237
| test("processes all v1 records successfully and returns no batch failures", async () => { | ||
| const evt: SQSEvent = { | ||
| Records: [ | ||
| createSqsRecord( | ||
| "msg1", | ||
| JSON.stringify(createNotification(createPreparedV1Event())), | ||
| ), | ||
| createSqsRecord( | ||
| "msg2", | ||
| JSON.stringify( | ||
| createNotification( | ||
| createPreparedV1Event({ | ||
| id: "7b9a03ca-342a-4150-b56b-989109c45614", | ||
| domainId: "letter2", | ||
| url: "s3://letterDataBucket/letter2.pdf", | ||
| }), | ||
| ), | ||
| ), | ||
| ), | ||
| ], | ||
| }; |
Contributor
There was a problem hiding this comment.
A parameterised test structure might be worth considering - maybe as a tech debt - as for each path (insert or upsert) I expect regardless of the supported event input we would want the same outputs.
Although it would still require extra tests for mixed events etc, I wonder if it might be easier to maintain/reduce the boilerplate?
|
|
||
| await Promise.all(tasks); | ||
|
|
||
| return { batchItemFailures }; |
Contributor
There was a problem hiding this comment.
Does batch failure support not require a terraform configuration to be set on the queue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.