Skip to content

Cleanup branch unit test#446

Open
nkoukpaizan wants to merge 2 commits into
developfrom
nicholson/fix-branch-accessor-test
Open

Cleanup branch unit test#446
nkoukpaizan wants to merge 2 commits into
developfrom
nicholson/fix-branch-accessor-test

Conversation

@nkoukpaizan

@nkoukpaizan nkoukpaizan commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Description

Looks like something went wrong in #417 . The accessor method in BranchTests is not called from runBranchTests, and it somehow contains Jacobian tests.

Proposed changes

  • Remove accessor method. It was replaced with parameterSetters.
  • [Minor] Remove ad-hoc tol = 1e-12 The default for isEqual should work.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • [N/A] The new code follows GridKit™ style guidelines.
  • [N/A] There are unit tests for the new code.
  • [N/A] The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • [N/A] I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

Further comments

@nkoukpaizan nkoukpaizan self-assigned this Jun 10, 2026
@nkoukpaizan nkoukpaizan added bug Something isn't working cleanup labels Jun 10, 2026
@nkoukpaizan nkoukpaizan marked this pull request as ready for review June 10, 2026 21:49
@nkoukpaizan nkoukpaizan requested review from lukelowry and pelesh and removed request for lukelowry June 10, 2026 21:49

@lukelowry lukelowry left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears I forgot to remove the old function after I made parameterSetters. Thank you. Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants