Skip to content

Cleanup branch unit test #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nkoukpaizan wants to merge 2 commits into
base: develop
Choose a base branch
from
+13 −72
Open

Cleanup branch unit test #446

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54c0d99
Remove unused, misleading accessor() method from BranchTests.
nkoukpaizan Jun 10, 2026
f479cf0
Remove ad-hoc tolerances
nkoukpaizan Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 13 additions & 72 deletions tests/UnitTests/PhasorDynamics/BranchTests.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,10 @@ namespace GridKit
branch.allocate();
branch.evaluateResidual();

const RealT tol{1.0e-12};
success *= isEqual(bus1.Ir(), Ir1, tol);
success *= isEqual(bus1.Ii(), Ii1, tol);
success *= isEqual(bus2.Ir(), Ir2, tol);
success *= isEqual(bus2.Ii(), Ii2, tol);
success *= isEqual(bus1.Ir(), Ir1);
success *= isEqual(bus1.Ii(), Ii1);
success *= isEqual(bus2.Ir(), Ir2);
success *= isEqual(bus2.Ii(), Ii2);

return success.report(__func__);
}
Expand Down Expand Up @@ -219,67 +218,11 @@ namespace GridKit
std::vector<DependencyTracking::Variable> residuals{bus1.Ir(), bus1.Ii(), bus2.Ir(), bus2.Ii()};
std::vector<DependencyTracking::Variable::DependencyMap> ref = analyticalJacobian(R, X, G, B, tap, phase);

const RealT tol{1.0e-12};
for (size_t i = 0; i < residuals.size(); ++i)
{
DependencyTracking::Variable res = residuals[i];
const DependencyTracking::Variable::DependencyMap& dependencies = res.getDependencies();
success *= (GridKit::Testing::isEqual(dependencies, ref[i], tol));
}

return success.report(__func__);
}

TestOutcome accessors()
{
// Verifies tap and phase-shift residual derivatives.
TestStatus success = true;

RealT R{2.0};
RealT X{4.0};
RealT G{0.2};
RealT B{1.2};
RealT tap{1.25};
RealT phase{0.3};

DependencyTracking::Variable Vr1{10.0};
DependencyTracking::Variable Vi1{20.0};
DependencyTracking::Variable Vr2{30.0};
DependencyTracking::Variable Vi2{40.0};

PhasorDynamics::Bus<DependencyTracking::Variable, IdxT> bus1(Vr1, Vi1);
PhasorDynamics::Bus<DependencyTracking::Variable, IdxT> bus2(Vr2, Vi2);
bus1.allocate();
bus1.initialize();
bus1.evaluateResidual();
bus2.allocate();
bus2.initialize();
bus2.evaluateResidual();
bus1.Vr().setVariableNumber(0);
bus1.Vi().setVariableNumber(1);
bus2.Vr().setVariableNumber(2);
bus2.Vi().setVariableNumber(3);

PhasorDynamics::Branch<DependencyTracking::Variable, IdxT> branch(&bus1,
&bus2,
R,
X,
G,
B,
tap,
phase);
branch.allocate();
branch.evaluateResidual();

std::vector<DependencyTracking::Variable> residuals{bus1.Ir(), bus1.Ii(), bus2.Ir(), bus2.Ii()};
std::vector<DependencyTracking::Variable::DependencyMap> ref = analyticalJacobian(R, X, G, B, tap, phase);

const RealT tol{1.0e-12};
for (size_t i = 0; i < residuals.size(); ++i)
{
DependencyTracking::Variable res = residuals[i];
const DependencyTracking::Variable::DependencyMap& dependencies = res.getDependencies();
success *= (GridKit::Testing::isEqual(dependencies, ref[i], tol));
success *= (GridKit::Testing::isEqual(dependencies, ref[i]));
}

return success.report(__func__);
Expand Down Expand Up @@ -332,11 +275,10 @@ namespace GridKit
ref_branch.evaluateResidual();
test_branch.evaluateResidual();

const RealT tol{1.0e-12};
success *= isEqual(test_bus1.Ir(), ref_bus1.Ir(), tol);
success *= isEqual(test_bus1.Ii(), ref_bus1.Ii(), tol);
success *= isEqual(test_bus2.Ir(), ref_bus2.Ir(), tol);
success *= isEqual(test_bus2.Ii(), ref_bus2.Ii(), tol);
success *= isEqual(test_bus1.Ir(), ref_bus1.Ir());
success *= isEqual(test_bus1.Ii(), ref_bus1.Ii());
success *= isEqual(test_bus2.Ir(), ref_bus2.Ir());
success *= isEqual(test_bus2.Ii(), ref_bus2.Ii());

return success.report(__func__);
}
Expand Down Expand Up @@ -415,11 +357,10 @@ namespace GridKit
data_branch.evaluateResidual();
ref_branch.evaluateResidual();

const RealT tol{1.0e-12};
success *= isEqual(data_bus1.Ir(), ref_bus1.Ir(), tol);
success *= isEqual(data_bus1.Ii(), ref_bus1.Ii(), tol);
success *= isEqual(data_bus2.Ir(), ref_bus2.Ir(), tol);
success *= isEqual(data_bus2.Ii(), ref_bus2.Ii(), tol);
success *= isEqual(data_bus1.Ir(), ref_bus1.Ir());
success *= isEqual(data_bus1.Ii(), ref_bus1.Ii());
success *= isEqual(data_bus2.Ir(), ref_bus2.Ir());
success *= isEqual(data_bus2.Ii(), ref_bus2.Ii());

return success.report(__func__);
}
Expand Down
Loading