fix: resolve Node 24+ spawn deprecation warning (DEP0190) #1130
+13
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using spawn with shell: true, passing args as a separate array causes a deprecation warning in Node 24+: 'Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.' This commit fixes the issue by joining the command and args into a single command string before passing to spawn, which is the recommended pattern for shell: true usage. Fixes OpenAPITools#1102
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
|
🎉 This PR is included in version 2.28.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the Node 24+ deprecation warning (DEP0190) that occurs when running the tool:
Changes
When using
spawn()withshell: true, Node 24 now warns if args are passed as a separate array because they get concatenated internally anyway. This PR joins the command and arguments into a single command string before passing tospawn(), which is the recommended pattern.Files modified:
pass-through.service.ts- Join command and args before spawningversion-manager.service.ts- Fix docker rmi and pull spawn callspass-through.service.spec.ts- Update test expectations to match new signatureTesting
Updated unit tests to reflect the new spawn signature. The behavior remains identical - only the way arguments are passed to spawn has changed.
Fixes #1102
Summary by cubic
Fixes the Node 24+ DEP0190 warning by switching spawn calls with shell: true to a single command string, removing the deprecation warning without changing behavior. Fixes #1102.
Written for commit 0a1328a. Summary will update on new commits.