Skip to content

fix: resolve Node 24+ spawn deprecation warning (DEP0190) #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 1 commit into from
Feb 10, 2026
Merged

fix: resolve Node 24+ spawn deprecation warning (DEP0190) #1130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions apps/generator-cli/src/app/services/pass-through.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,7 @@ describe('PassThroughService', () => {
await program.parseAsync([name, ...argv], { from: 'user' });
expect(childProcess.spawn).toHaveBeenNthCalledWith(
1,
'docker run --rm -v "/foo/bar:/local" openapitools/openapi-generator-cli:v4.2.1',
[name, ...argv],
`docker run --rm -v "/foo/bar:/local" openapitools/openapi-generator-cli:v4.2.1 ${name} ${argv.join(' ')}`,
{
stdio: 'inherit',
shell: true,
Expand All @@ -192,8 +191,7 @@ describe('PassThroughService', () => {
await program.parseAsync([name, ...argv], { from: 'user' });
expect(childProcess.spawn).toHaveBeenNthCalledWith(
1,
'java -jar "/some/path/to/4.2.1.jar"',
[name, ...argv],
`java -jar "/some/path/to/4.2.1.jar" ${name} ${argv.join(' ')}`,
{
stdio: 'inherit',
shell: true,
Expand All @@ -206,8 +204,7 @@ describe('PassThroughService', () => {
await program.parseAsync([name, ...argv], { from: 'user' });
expect(childProcess.spawn).toHaveBeenNthCalledWith(
1,
'java java-opt-1=1 -jar "/some/path/to/4.2.1.jar"',
[name, ...argv],
`java java-opt-1=1 -jar "/some/path/to/4.2.1.jar" ${name} ${argv.join(' ')}`,
{
stdio: 'inherit',
shell: true,
Expand All @@ -227,8 +224,7 @@ describe('PassThroughService', () => {
`java -cp "${[
'/some/path/to/4.2.1.jar',
'../some/custom.jar',
].join(cpDelimiter)}" org.openapitools.codegen.OpenAPIGenerator`,
[name, ...argv],
].join(cpDelimiter)}" org.openapitools.codegen.OpenAPIGenerator ${name} ${argv.join(' ')}`,
{
stdio: 'inherit',
shell: true,
Expand Down Expand Up @@ -303,8 +299,7 @@ describe('PassThroughService', () => {
it('spawns the correct process', () => {
expect(childProcess.spawn).toHaveBeenNthCalledWith(
1,
'java -jar "/some/path/to/4.2.1.jar"',
cmd.split(' '),
`java -jar "/some/path/to/4.2.1.jar" ${cmd}`,
{ stdio: 'inherit', shell: true }
);
});
Expand Down
5 changes: 4 additions & 1 deletion apps/generator-cli/src/app/services/pass-through.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,11 @@ export class PassThroughService {

public passThrough = (cmd: Command) => {
const args = [cmd.name(), ...cmd.args];
// Join command and args into a single string to avoid Node 24+ deprecation warning
// DEP0190: passing args to spawn with shell: true concatenates without escaping
const fullCommand = [this.cmd(), ...args].join(' ');

spawn(this.cmd(), args, {
spawn(fullCommand, {
stdio: 'inherit',
shell: true,
}).on('exit', process.exit);
Expand Down
6 changes: 4 additions & 2 deletions apps/generator-cli/src/app/services/version-manager.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,8 @@ export class VersionManagerService {
async remove(versionName: string) {
if (this.configService.useDocker) {
await new Promise<void>((resolve) => {
spawn('docker', ['rmi', this.getDockerImageName(versionName)], {
// Use single command string to avoid Node 24+ deprecation warning (DEP0190)
spawn(`docker rmi ${this.getDockerImageName(versionName)}`, {
stdio: 'inherit',
shell: true,
}).on('exit', () => resolve());
Expand All @@ -151,7 +152,8 @@ export class VersionManagerService {

if (this.configService.useDocker) {
await new Promise<void>((resolve) => {
spawn('docker', ['pull', this.getDockerImageName(versionName)], {
// Use single command string to avoid Node 24+ deprecation warning (DEP0190)
spawn(`docker pull ${this.getDockerImageName(versionName)}`, {
stdio: 'inherit',
shell: true,
}).on('exit', () => resolve());
Expand Down