ServoDyn-StC: StC_SA_MODE validation logic#3348
Open
RBergua wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged
Feature or improvement description
I have been using the Structural Control (StC) module and observed that the Semi_Active control mode (
StC_SA_MODE) was validated unconditionally.For example, using the Active Control Mode through user subroutine (
StC_CMODE = 3), the code would still check for a valid Semi Active Control Mode:And OpenFAST aborts if no valid mode is selected:
To avoid this friction for the user, the source code has been updated and the validation logic for the semi-active control mode only applies if
StC_CMODE = 1.In addition, the input files have been updated to clarify this (see PR in r-test: OpenFAST/r-test#181):
1 StC_SA_MODE - Semi-Active control mode {1: velocity-based ground hook control; 2: Inverse velocity-based ground hook control; 3: displacement-based ground hook control 4: Phase difference Algorithm with Friction Force 5: Phase difference Algorithm with Damping Force} [used only when StC_CMODE=1]