Fix rent and childcare export inputs#190
Merged
Merged
Conversation
1103c9e to
3e008ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pre_subsidy_rentfrom ACS-imputedrentbefore PE formula materialization, so formula-ownedrentdoes not overwrite the donor value to zerorentthrough the storable PE/eCPSpre_subsidy_rentinput when building H5 arrays, while still excluding formula-ownedrentitselfspm_unit_pre_subsidy_childcare_expensesin cached person rows so stale pre-Populate rent (ACS donor) and childcare (CPS ASEC) — close Gate-2 zero-targets #180 caches rebuildValidation
uv run --python 3.13 --extra dev --extra policyengine pytest tests/policyengine/test_us.py::TestPolicyEngineUSProjection tests/test_cps_source_provider.py tests/pipelines/test_us.py::TestUSMicroplexPipeline::test_augment_policyengine_person_inputs_aliases_rent_to_pre_subsidy_rent tests/pipelines/test_us.py::TestUSMicroplexPipeline::test_build_policyengine_entity_tables_preserves_spm_source_inputsuv run --python 3.13 --extra dev ruff check src/microplex_us/data_sources/cps.py src/microplex_us/policyengine/us.py src/microplex_us/pipelines/us.py tests/test_cps_source_provider.py tests/policyengine/test_us.py tests/pipelines/test_us.pyuv run --python 3.13 --extra dev ruff format --check src/microplex_us/data_sources/cps.py src/microplex_us/policyengine/us.py src/microplex_us/pipelines/us.py tests/test_cps_source_provider.py tests/policyengine/test_us.py tests/pipelines/test_us.pyrentrows become 500 nonzeropre_subsidy_rentrows after_augment_policyengine_person_inputs, max preserved at 63,600Release-candidate context
The #185 RC build passed export-column parity but failed the manual support audit because
pre_subsidy_rentandspm_unit_pre_subsidy_childcare_expenseswere all zero in the H5. The source stage had nonzero ACS-imputedrent, but post-microsimrentwas all zero because PE materialization recomputed formula-ownedrentfrom missingpre_subsidy_rent. Childcare was parsed from CPS but the active build reused the pre-#180 processed CPS cache.