Skip to content

feat: Upgrade Claude adapter to SDK 0.3 with native binary#2385

Merged
k11kirky merged 8 commits into
mainfrom
05-26-upgrade_claude_adapter
May 29, 2026
Merged

feat: Upgrade Claude adapter to SDK 0.3 with native binary#2385
k11kirky merged 8 commits into
mainfrom
05-26-upgrade_claude_adapter

Conversation

@charlesvien
Copy link
Copy Markdown
Member

@charlesvien charlesvien commented May 27, 2026

Problem

It's that time of the month again, claude adapter update! We pinned the adapter to SDK 0.2.112 for awhile because 0.2.114 broke session init; meanwhile upstream shipped Task tools, MCP changes and ACP 0.22. Lots of bug fixes + supposed session initialization timing improvements being adopted.

Changes

  1. Bump claude-agent-sdk, ACP SDK, anthropic SDK
  2. Port TodoWrite -> Task tools migration with a per-session task map and TaskCreated/TaskCompleted hook handlers
  3. Switch session resume to the new resumeSession API (was unstable_resumeSession) for ACP 0.22
  4. Set MCP_CONNECTION_NONBLOCKING=0 so MCP servers stay blocking-connect and tools are ready on first prompt
  5. Ship native Claude binary in the bundle and harden vite packaging for cross-arch macOS/win/linux builds
  6. Add unit tests for hooks, models, settings, and task-state conversion

How did you test this?

Manually

Publish to changelog?

no

@charlesvien charlesvien changed the title Upgrade claude adapter feat: Upgrade Claude adapter to SDK 0.3 with native binary May 27, 2026
@charlesvien charlesvien marked this pull request as ready for review May 27, 2026 02:28
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 27, 2026

T-Rex T-Rex Logs

What T-Rex did

  • Ran native Claude binary resolution across platform and architecture inputs, including Windows binary naming and Linux libc candidate ordering.
  • Ran TaskCreate and TaskUpdate plan-state conversion checks, including missing output, deleted tasks, ordering, and text-block parsing.
  • Checked task hook ordering and duplicate handling for TaskCreated and TaskCompleted events.
  • Ran MCP server parsing checks for http, sse, stdio, and unsupported sdk-type entries.
  • Checked model alias resolution, capability gating, and local-command marker stripping behavior.
Artifacts

Comprehensive proof-of-work results

  • Aggregates logs and results covering binary resolution, task state conversions, hook ordering, MCP config parsing, and model resolution checks to help verify the code-execution checks.

Task state conversion checks

  • Keeps the command output available without making the summary code-heavy.

Task hook ordering checks

  • Keeps the command output available without making the summary code-heavy.

MCP config parsing checks

  • Keeps the command output available without making the summary code-heavy.

Model resolution checks

  • Keeps the command output available without making the summary code-heavy.

Local command marker stripping checks

  • Keeps the command output available without making the summary code-heavy.

T-Rex Ran code and verified through T-Rex

Reviews (1): Last reviewed commit: "harden native claude binary packaging fo..." | Re-trigger Greptile

Comment thread packages/agent/src/adapters/claude/claude-agent.ts Outdated
@charlesvien charlesvien force-pushed the 05-26-upgrade_claude_adapter branch 2 times, most recently from b1848c0 to e2b442e Compare May 28, 2026 22:27
@charlesvien charlesvien changed the base branch from main to graphite-base/2385 May 28, 2026 22:31
@charlesvien charlesvien force-pushed the 05-26-upgrade_claude_adapter branch from e2b442e to 70de38a Compare May 28, 2026 22:31
@charlesvien charlesvien changed the base branch from graphite-base/2385 to 05-28-gate_unsupported-slash-command_on_sdk_command_list May 28, 2026 22:31
@charlesvien charlesvien force-pushed the 05-26-upgrade_claude_adapter branch from 70de38a to 9c77bbd Compare May 29, 2026 02:33
@charlesvien charlesvien force-pushed the 05-28-gate_unsupported-slash-command_on_sdk_command_list branch from e8eb279 to 2cffc25 Compare May 29, 2026 02:33
@charlesvien charlesvien force-pushed the 05-28-gate_unsupported-slash-command_on_sdk_command_list branch from 2cffc25 to 4b1d6ed Compare May 29, 2026 02:48
@charlesvien charlesvien force-pushed the 05-26-upgrade_claude_adapter branch 2 times, most recently from 580854d to 3b2a044 Compare May 29, 2026 02:55
@charlesvien charlesvien force-pushed the 05-28-gate_unsupported-slash-command_on_sdk_command_list branch from 4b1d6ed to b7bd526 Compare May 29, 2026 02:55
@charlesvien charlesvien force-pushed the 05-26-upgrade_claude_adapter branch from 3b2a044 to 56bf9bd Compare May 29, 2026 03:16
@charlesvien charlesvien force-pushed the 05-28-gate_unsupported-slash-command_on_sdk_command_list branch 2 times, most recently from 44cf140 to 0edd3dc Compare May 29, 2026 05:19
@charlesvien charlesvien force-pushed the 05-26-upgrade_claude_adapter branch from b62ad80 to e9fc89a Compare May 29, 2026 05:19
Copy link
Copy Markdown
Contributor

@k11kirky k11kirky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG!

@k11kirky k11kirky mentioned this pull request May 29, 2026
2 tasks
Copy link
Copy Markdown
Contributor

k11kirky commented May 29, 2026

Merge activity

  • May 29, 10:26 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 29, 10:46 AM UTC: Graphite rebased this pull request as part of a merge.
  • May 29, 11:01 AM UTC: @k11kirky merged this pull request with Graphite.

@k11kirky k11kirky changed the base branch from 05-28-gate_unsupported-slash-command_on_sdk_command_list to graphite-base/2385 May 29, 2026 10:36
@k11kirky k11kirky changed the base branch from graphite-base/2385 to main May 29, 2026 10:44
@k11kirky k11kirky force-pushed the 05-26-upgrade_claude_adapter branch from e9fc89a to 46187d8 Compare May 29, 2026 10:45
@k11kirky k11kirky force-pushed the 05-26-upgrade_claude_adapter branch from 46187d8 to 96e5861 Compare May 29, 2026 10:52
@k11kirky k11kirky merged commit cd39904 into main May 29, 2026
19 checks passed
@k11kirky k11kirky deleted the 05-26-upgrade_claude_adapter branch May 29, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants