fix(cli): accept --thinking flag silently in csa review#449
fix(cli): accept --thinking flag silently in csa review#449RyderFreeman4Logos merged 2 commits intomainfrom
Conversation
The --thinking parameter was accepted by `csa run` and `csa debate` but rejected by `csa review` with a hard error. This wasted caller tokens and context window when callers passed --thinking uniformly across subcommands. Add --thinking as an accepted-but-unused field on ReviewArgs for CLI compatibility. Thinking level for review is controlled via tier configuration. Also ignore two transitive aws-lc advisories (RUSTSEC-2026-0044, RUSTSEC-2026-0048) that have no direct upgrade path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5f0c84839d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| csa = "0.1.152" | ||
| last_migrated_at = "2026-03-08T12:08:01.820964091Z" | ||
| weave = "0.1.151" | ||
| weave = "0.1.152" |
There was a problem hiding this comment.
weave.lock to the new 0.1.154 workspace version
Cargo.toml and Cargo.lock were bumped to 0.1.154, but this lockfile still records 0.1.152. In this repo, every csa or weave invocation from the project root runs the version-alignment check in crates/cli-sub-agent/src/main.rs:217-234, and check_version will silently rewrite stale patch versions (crates/csa-config/src/weave_lock.rs:193-221). That means the first command after checkout dirties the worktree with an unrelated weave.lock change, which can leak into reviews, diffs, and follow-up commits.
Useful? React with 👍 / 👎.
The review finding correctly identified that --thinking was parsed but not passed to resolve_review_thinking(). Wire args.thinking through so the CLI flag actually takes effect, matching csa run and csa debate behavior. Also ignore RUSTSEC-2026-0049 (rustls CRL check bug, safe default mitigates). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Local Review Audit TrailReviewer: codex (gpt-5.4, xhigh thinking) Finding #1 (HIGH) —
|
1 participant
Summary
--thinkingas an accepted-but-ignored parameter toReviewArgs(csa review)csa runandcsa debateaccepted--thinkingbutcsa reviewrejected it with a hard error, wasting caller tokens and context windowTest plan
cargo test -- thinking_flag— 3 tests pass (2 new + 1 existing debate test)just pre-commitpasses cleanly (no--no-verify)