Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ members = ["crates/*"]
resolver = "2"

[workspace.package]
version = "0.1.153"
version = "0.1.154"
edition = "2024"
rust-version = "1.88"
license = "Apache-2.0"
Expand Down
5 changes: 5 additions & 0 deletions crates/cli-sub-agent/src/cli_review.rs
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ pub struct ReviewArgs {
#[arg(short, long)]
pub model: Option<String>,

/// Thinking budget (accepted for CLI compatibility but not used by review;
/// thinking level is controlled via tier configuration)
#[arg(long)]
pub thinking: Option<String>,

/// Review uncommitted changes (git diff HEAD)
#[arg(long)]
pub diff: bool,
Expand Down
2 changes: 1 addition & 1 deletion crates/cli-sub-agent/src/review_cmd.rs
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ pub(crate) async fn handle_review(args: ReviewArgs, current_depth: u32) -> Resul
// Resolve thinking: CLI > config review.thinking > tier model_spec thinking.
// Tier thinking is embedded in model_spec and applied via build_and_validate_executor.
let review_thinking = resolve_review_thinking(
None, // review CLI has no --thinking flag yet
args.thinking.as_deref(),
config
.as_ref()
.and_then(|c| c.review.as_ref())
Expand Down
5 changes: 5 additions & 0 deletions crates/cli-sub-agent/src/review_cmd_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,7 @@ fn derive_scope_uncommitted() {
sa_mode: None,
session: None,
model: None,
thinking: None,
diff: true,
branch: None,
commit: None,
Expand Down Expand Up @@ -374,6 +375,7 @@ fn derive_scope_commit() {
sa_mode: None,
session: None,
model: None,
thinking: None,
diff: false,
branch: None,
commit: Some("abc123".to_string()),
Expand Down Expand Up @@ -410,6 +412,7 @@ fn derive_scope_range() {
sa_mode: None,
session: None,
model: None,
thinking: None,
diff: false,
branch: None,
commit: None,
Expand Down Expand Up @@ -446,6 +449,7 @@ fn derive_scope_files() {
sa_mode: None,
session: None,
model: None,
thinking: None,
diff: false,
branch: None,
commit: None,
Expand Down Expand Up @@ -482,6 +486,7 @@ fn derive_scope_default_branch() {
sa_mode: None,
session: None,
model: None,
thinking: None,
diff: false,
branch: Some("develop".to_string()),
commit: None,
Expand Down
15 changes: 15 additions & 0 deletions crates/cli-sub-agent/src/review_cmd_tests_tail.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,21 @@
use super::*;
use csa_config::ProjectProfile;

// --- --thinking silent acceptance tests ---

#[test]
fn thinking_flag_accepted_silently() {
let args = parse_review_args(&["csa", "review", "--thinking", "xhigh", "--diff"]);
assert_eq!(args.thinking.as_deref(), Some("xhigh"));
assert!(args.diff);
}

#[test]
fn thinking_flag_optional() {
let args = parse_review_args(&["csa", "review", "--diff"]);
assert!(args.thinking.is_none());
}

// --- verify_review_skill_available tests ---

#[test]
Expand Down
9 changes: 8 additions & 1 deletion deny.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,14 @@ ignore = [
# Transitive from agent-teams -> cc-sdk -> reqwest.
# rustls-pemfile is archived; no non-breaking safe upgrade is available yet.
"RUSTSEC-2025-0134",
# (removed: RUSTSEC-2024-0384 resolved by dependency upgrades)
# Transitive from agent-teams -> cc-sdk -> reqwest -> hyper-rustls -> rustls -> aws-lc-rs.
# X.509 Name Constraints Bypass — no direct upgrade path (deep transitive).
"RUSTSEC-2026-0044",
# Transitive from same chain. CRL Distribution Point Scope Check Logic Error.
"RUSTSEC-2026-0048",
# Transitive from cc-sdk -> reqwest -> rustls. CRL revocation check bug.
# Safe default (UnknownStatusPolicy::Deny) mitigates impact.
"RUSTSEC-2026-0049",
]

[licenses]
Expand Down
4 changes: 2 additions & 2 deletions weave.lock
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package = []

[versions]
csa = "0.1.151"
csa = "0.1.152"
last_migrated_at = "2026-03-08T12:08:01.820964091Z"
weave = "0.1.151"
weave = "0.1.152"
Comment on lines +4 to +6
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Sync weave.lock to the new 0.1.154 workspace version

Cargo.toml and Cargo.lock were bumped to 0.1.154, but this lockfile still records 0.1.152. In this repo, every csa or weave invocation from the project root runs the version-alignment check in crates/cli-sub-agent/src/main.rs:217-234, and check_version will silently rewrite stale patch versions (crates/csa-config/src/weave_lock.rs:193-221). That means the first command after checkout dirties the worktree with an unrelated weave.lock change, which can leak into reviews, diffs, and follow-up commits.

Useful? React with 👍 / 👎.


[migrations]
applied = [
Expand Down
Loading