Skip to content

Add the web component from checkout-web internal#83

Closed
toneymathews wants to merge 1 commit into
graphite-base/83from
port-web-component-from-checkout-web-internal
Closed

Add the web component from checkout-web internal#83
toneymathews wants to merge 1 commit into
graphite-base/83from
port-web-component-from-checkout-web-internal

Conversation

@toneymathews
Copy link
Copy Markdown
Contributor

@toneymathews toneymathews commented May 13, 2026

What changes are you making?

Porting over the web-component from Checkout Web over to the repo. Key points

  • I've ported the internal version over
  • Types that were imported from embed are now created in checkout.types.ts

How to test


Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in platforms/swift/ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated platforms/swift/CHANGELOG.md
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Android version?
  • I have bumped the versionName in platforms/android/lib/build.gradle
  • I have updated platforms/android/CHANGELOG.md
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

Copy link
Copy Markdown
Contributor Author

toneymathews commented May 13, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@toneymathews toneymathews changed the base branch from main to graphite-base/83 May 13, 2026 19:37
@toneymathews toneymathews force-pushed the port-web-component-from-checkout-web-internal branch from 274470d to 5b2e4a8 Compare May 13, 2026 19:37
@toneymathews toneymathews changed the base branch from graphite-base/83 to checkout-kit-web May 13, 2026 19:37
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026

Web — Coverage Report

Lines Statements Branches Functions
Coverage: 90%
90.1% (583/647) 83.03% (137/165) 88.57% (62/70)

@toneymathews toneymathews force-pushed the port-web-component-from-checkout-web-internal branch from 5b2e4a8 to 64610d2 Compare May 13, 2026 20:26
@westeezy westeezy changed the base branch from checkout-kit-web to graphite-base/83 May 13, 2026 21:24
@westeezy westeezy mentioned this pull request May 14, 2026
11 tasks
This was referenced May 14, 2026
@westeezy westeezy closed this May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants