Migrate Legacy NodeId Utilities to NodeManager#1015
Closed
camielvs wants to merge 1 commit intographite-base/1015from
Closed
Migrate Legacy NodeId Utilities to NodeManager#1015camielvs wants to merge 1 commit intographite-base/1015from
camielvs wants to merge 1 commit intographite-base/1015from
Conversation
This was referenced Sep 30, 2025
Closed
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Sep 30, 2025
Closed
camielvs
force-pushed
the
09-29-migrate_legacy_nodeid_utilities_to_nodemanager
branch
from
320479e to
7d107bc
Compare
camielvs
force-pushed
the
09-29-implement_node_manager
branch
from
8c27ed8 to
46676ff
Compare
This was referenced Oct 2, 2025
camielvs
force-pushed
the
09-29-migrate_legacy_nodeid_utilities_to_nodemanager
branch
from
7d107bc to
3321611
Compare
camielvs
force-pushed
the
09-29-implement_node_manager
branch
from
46676ff to
9cab80e
Compare
camielvs
force-pushed
the
09-29-migrate_legacy_nodeid_utilities_to_nodemanager
branch
from
3321611 to
2f84d5f
Compare
camielvs
force-pushed
the
09-29-implement_node_manager
branch
from
9cab80e to
50cbbc2
Compare
camielvs
changed the base branch from
09-29-implement_node_manager
to
graphite-base/1015
This was referenced Oct 8, 2025
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Folded into #1004
Replace all existing name->node id conversions with NodeManager. To facilitate this the
useNodeManagerhook was added.Also implements a clearer delineation between io name, io id and node id.
All tasks and nodes will now run on the new node manager id system
Related Issue and Pull requests
Progresses Progresses Shopify/oasis-frontend#261
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Additional Comments