Separate IONodeData type from TaskNodeData type by camielvs · Pull Request #928 · TangleML/tangle-ui

camielvs · 2025-09-19T23:16:30Z

Description

Separates the NodeData types for IO Nodes vs Task Nodes. This allows stricter and more easily-followed type definitions for data within nodes. e.g. IO Nodes will no longer receive pointless amounts of task-node data such as isGhost or callbacks.

taskNode type file and hintNode type file have also been co-located together into a singular nodes type file.

No change to app functionality.

Related Issue and Pull requests

Closes https://github.com/Shopify/oasis-frontend/issues/327

Type of Change

Cleanup/Refactor

Checklist

I have tested this does not break current pipelines / runs functionality
I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

Task Nodes

Create a task node

Drag a component from the library onto the canvas
Verify the node renders correctly with all task information

Edit task node arguments

Click on a task node
Modify arguments in the context panel
Verify changes are saved correctly

Delete a task node

Select a task node and delete it
Verify the node is removed from the canvas and graph

Duplicate a task node

Select a task node and duplicate it
Verify the duplicate appears with a unique ID

Input/Output Nodes

Create input and output nodes

Add an input node to the canvas
Add an output node to the canvas
Verify both render with correct labels and type information

Edit IO node properties

Click on an input/output node
Modify its properties in the context panel (name, type, default value)
Verify changes are reflected in the node

Connect IO nodes

Connect an input node to a task node input
Connect a task node output to an output node
Verify connections work correctly

General Operations

Copy and paste nodes

Select multiple nodes (mix of task, input, output)
Copy and paste them
Verify all node types paste correctly with proper data

(note some existing copy + paste functionality does not work with IO nodes)

Undo/redo operations

Perform various operations on different node types
Test undo/redo functionality
Verify all node types maintain correct state

Save and reload

Make changes to a component with various node types
Save the component
Reload and verify all nodes retain their data correctly

Additional Comments

camielvs · 2025-09-19T23:16:42Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

useNodeManager Hook #1082 : 2 dependent PRs (#930 , #1004 )
Provide Node Manager #1081
Add Node Manager #929
Groundwork for Id Conversions #1090
Separate IONodeData type from TaskNodeData type #928 👈 (View in Graphite)
Refactor Dynamic Node Callbacks #927
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Mbeaulne

inputs and outputs are now registering as output nodes

Mbeaulne

inputs and outputs are now registering as output nodes

camielvs · 2025-10-23T16:38:16Z

Fixed - it appears we don't have enough info for the new isInputSpec method to infer whether a node is an Input or Output. I've now added a secondary check via node.type.

maxy-shpfy

Small regression (compared to staging - at the end of the video):

create Input node. It is marked as "INVALID" at 3 places (pipeline validation, canvas node, context panel).
input value. Validation now passed.
remove value. Validation fails again. But now the node is Marked as INVALID just in 2 places (canvas node skipped). --- BUG

Screen Recording 2025-10-23 at 4.24.47 PM.mov (uploaded via Graphite)

camielvs · 2025-10-24T00:17:58Z

Fixed!

## Description  Adds a specific context panel view for when multiple nodes are selected. The new view shows a list of selected nodes followed by the standard array of multi-select toolbar actions. The nodes in the list can be selected to open their specific context panels, with a "back" button to go back to the multiselection panel. ## Related Issue and Pull requests  Closes Shopify/oasis-frontend#497 ## Type of Change  - [x] Improvement ## Checklist  - [ ] I have tested this does not break current pipelines / runs functionality - [ ] I have tested the changes on staging ## Screenshots (if applicable)  ![image.png](https://app.graphite.com/user-attachments/assets/4fd885c1-8570-4440-af9d-bd98c4246fb9.png) ![image.png](https://app.graphite.com/user-attachments/assets/80e049ee-36ac-41e5-a618-efa9698abb66.png) ## Test Instructions - Confirm you can select multiple nodes and view the panel on both Edit and Run pages - Confirm you can select an individual node with the group via the context panel to view its specific details, and can then go back - Confirm that updating a task, input, output, flex node from within the multiselect flow does not break the flow  ## Additional Comments This PR also refines the naming process for Sticky Notes. There is a multiselect check added inside each of task, io and flex nodes to avoid a race condition on displaying content in the context panel. I absolutely loathe the process for adding a new callback to a task and the extremely loose typing associated with tasks. I would love to address this as done in #928 though I also understand it may be addressed as part of the Object-Model work. Deleting a node from with the multiselect interface and then undoing via ctrl+z will not restore the node to the select because the selection is managed by reactflow whilst undo/redo is via the component spec.

camielvs · 2026-04-24T21:07:35Z

Closed in favour of v2 Editor migration. See #2028

camielvs mentioned this pull request Sep 19, 2025

Refactor Dynamic Node Callbacks #927

Closed

3 tasks

camielvs force-pushed the 09-19-stricter_typing_on_nodes branch from ae98a84 to 9a5b19a Compare September 19, 2025 23:23

camielvs force-pushed the 09-19-refactor_tasknode_callback_generation branch from 103acce to 9596f63 Compare September 19, 2025 23:23

camielvs force-pushed the 09-19-stricter_typing_on_nodes branch from 9a5b19a to 36694ff Compare September 19, 2025 23:28

camielvs force-pushed the 09-19-refactor_tasknode_callback_generation branch from 9596f63 to 35a7502 Compare September 19, 2025 23:28

camielvs force-pushed the 09-19-stricter_typing_on_nodes branch from 36694ff to 4fc8990 Compare September 19, 2025 23:42

camielvs force-pushed the 09-19-refactor_tasknode_callback_generation branch from 35a7502 to 0b3349b Compare September 19, 2025 23:42

camielvs changed the title ~~Stricter Typing on Nodes~~ Add IONodeData Type Sep 19, 2025

camielvs force-pushed the 09-19-stricter_typing_on_nodes branch from 4fc8990 to 34238bb Compare September 19, 2025 23:57

camielvs changed the title ~~Add IONodeData Type~~ Separate IONodeData type from TaskNodeData type Sep 19, 2025

This was referenced Sep 20, 2025

Add Node Manager #929

Closed

Implement Node Manager [old] #930

Closed

camielvs force-pushed the 09-19-stricter_typing_on_nodes branch from 34238bb to 11d5dce Compare September 20, 2025 00:31

camielvs force-pushed the 09-19-refactor_tasknode_callback_generation branch from 0b3349b to 87e51db Compare September 20, 2025 00:31

camielvs force-pushed the 09-19-stricter_typing_on_nodes branch from 11d5dce to 7dcc9ba Compare September 29, 2025 19:44

camielvs force-pushed the 09-19-refactor_tasknode_callback_generation branch from 87e51db to b50521d Compare September 29, 2025 19:44

camielvs force-pushed the 09-19-stricter_typing_on_nodes branch from 7dcc9ba to eae31b0 Compare September 29, 2025 20:08

This was referenced Sep 29, 2025

Implement Node Manager #1004

Closed

Migrate Legacy NodeId Utilities to NodeManager #1015

Closed

Add debug mode for viewing ReactFlow Node ids #1016

Closed

Split TaskInput and TaskOutput Node Ids from Input and Output Node Ids #1017

Closed

camielvs force-pushed the 09-19-stricter_typing_on_nodes branch from eae31b0 to 9511aeb Compare October 1, 2025 23:16

camielvs force-pushed the 09-19-refactor_tasknode_callback_generation branch from b50521d to 770419a Compare October 1, 2025 23:16

This was referenced Oct 2, 2025

Rework TaskInput and TaskOutput logic #1039

Closed

Fix inability to delete edges #1040

Closed

camielvs force-pushed the 09-19-refactor_tasknode_callback_generation branch from 770419a to cbcb1f5 Compare October 7, 2025 22:53

camielvs force-pushed the 09-19-stricter_typing_on_nodes branch from 9511aeb to a6337e1 Compare October 7, 2025 22:53

This was referenced Oct 7, 2025

Provide Node Manager #1081

Closed

useNodeManager Hook #1082

Closed

camielvs requested a review from Mbeaulne October 22, 2025 22:20

Mbeaulne reviewed Oct 23, 2025

View reviewed changes

Mbeaulne requested changes Oct 23, 2025

View reviewed changes

camielvs force-pushed the 09-19-stricter_typing_on_nodes branch from fbab826 to 95162d3 Compare October 23, 2025 16:35

camielvs force-pushed the 09-19-refactor_tasknode_callback_generation branch from c426542 to 7bcc36b Compare October 23, 2025 16:35

camielvs requested a review from Mbeaulne October 23, 2025 16:38

camielvs mentioned this pull request Oct 23, 2025

Fix Disconnected Output Nodes when Copy + Paste between Tabs #1186

Closed

3 tasks

camielvs force-pushed the 09-19-refactor_tasknode_callback_generation branch from 7bcc36b to d9b0b7a Compare October 23, 2025 19:34

camielvs force-pushed the 09-19-stricter_typing_on_nodes branch from 95162d3 to 7d73c7d Compare October 23, 2025 19:34

Mbeaulne approved these changes Oct 23, 2025

View reviewed changes

camielvs force-pushed the 09-19-stricter_typing_on_nodes branch from 7d73c7d to 44c3648 Compare October 23, 2025 23:23

camielvs force-pushed the 09-19-refactor_tasknode_callback_generation branch from d9b0b7a to 5d5a668 Compare October 23, 2025 23:23

maxy-shpfy reviewed Oct 23, 2025

View reviewed changes

camielvs force-pushed the 09-19-stricter_typing_on_nodes branch from 44c3648 to b69aa27 Compare October 24, 2025 00:15

camielvs requested a review from maxy-shpfy October 24, 2025 00:18

camielvs force-pushed the 09-19-stricter_typing_on_nodes branch from b69aa27 to 68e7ba2 Compare October 28, 2025 21:04

camielvs force-pushed the 09-19-refactor_tasknode_callback_generation branch from 5d5a668 to 0c9c20e Compare October 28, 2025 21:04

maxy-shpfy marked this pull request as draft October 30, 2025 16:55

camielvs force-pushed the 09-19-stricter_typing_on_nodes branch from 68e7ba2 to de75893 Compare October 30, 2025 19:10

camielvs force-pushed the 09-19-refactor_tasknode_callback_generation branch from 0c9c20e to 8a86e79 Compare October 30, 2025 19:10

camielvs force-pushed the 09-19-stricter_typing_on_nodes branch from de75893 to 8b5a1d0 Compare October 30, 2025 19:44

Stricter Typing on Nodes

c5ed11d

camielvs force-pushed the 09-19-stricter_typing_on_nodes branch from 8b5a1d0 to c5ed11d Compare October 31, 2025 00:23

camielvs force-pushed the 09-19-refactor_tasknode_callback_generation branch from 8a86e79 to 9e0dc05 Compare October 31, 2025 00:23

camielvs mentioned this pull request Mar 4, 2026

feat: Multiselection Context Panel #1888

Merged

3 tasks

camielvs closed this Apr 24, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Separate IONodeData type from TaskNodeData type#928

Separate IONodeData type from TaskNodeData type#928
camielvs wants to merge 1 commit into09-19-refactor_tasknode_callback_generationfrom
09-19-stricter_typing_on_nodes

camielvs commented Sep 19, 2025 •

edited

Loading

Uh oh!

camielvs commented Sep 19, 2025 •

edited

Loading

Uh oh!

Mbeaulne left a comment

Uh oh!

Mbeaulne left a comment

Uh oh!

camielvs commented Oct 23, 2025 •

edited

Loading

Uh oh!

maxy-shpfy left a comment

Uh oh!

camielvs commented Oct 24, 2025

Uh oh!

camielvs commented Apr 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

camielvs commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue and Pull requests

Type of Change

Checklist

Screenshots (if applicable)

Test Instructions

Additional Comments

Uh oh!

camielvs commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mbeaulne left a comment

Choose a reason for hiding this comment

Uh oh!

Mbeaulne left a comment

Choose a reason for hiding this comment

Uh oh!

camielvs commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maxy-shpfy left a comment

Choose a reason for hiding this comment

Uh oh!

camielvs commented Oct 24, 2025

Uh oh!

camielvs commented Apr 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

camielvs commented Sep 19, 2025 •

edited

Loading

camielvs commented Sep 19, 2025 •

edited

Loading

camielvs commented Oct 23, 2025 •

edited

Loading