odb: Use snake_case for LEF58 parser variables in multiple files (#2275)#9721
Merged
eder-matheus merged 2 commits intoThe-OpenROAD-Project:masterfrom Mar 12, 2026
Merged
Conversation
…-OpenROAD-Project#2275) Signed-off-by: Divinesoumyadip <soumyacode7@gmail.com>
Divinesoumyadip
force-pushed
the
fix-2275-part2
branch
from
b0c02a6 to
b194f05
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
eder-matheus
requested changes
Mar 11, 2026
|
|
||
| qi::rule<std::string::const_iterator, space_type> LEF58_ARRAYSPACING | ||
| = (lit("ARRAYSPACING") >> -(CUTCLASS) | ||
| qi::rule<std::string::const_iterator, space_type> lef58_arrayspacing_rule |
Member
There was a problem hiding this comment.
lef58_arrayspacing_rule -> lef58_array_spacing_rule
| auto first = s.begin(); | ||
| auto last = s.end(); | ||
| bool valid = qi::phrase_parse(first, last, LEF58_ARRAYSPACING, space) | ||
| bool valid = qi::phrase_parse(first, last, lef58_arrayspacing_rule, space) |
Member
There was a problem hiding this comment.
lef58_arrayspacing_rule -> lef58_array_spacing_rule
| &odb::dbTechLayerKeepOutZoneRule::setSpiralExtension)])); | ||
|
|
||
| qi::rule<std::string::const_iterator, space_type> LEF58_KEEPOUTZONE | ||
| qi::rule<std::string::const_iterator, space_type> lef58_keepoutzone_rule |
Member
There was a problem hiding this comment.
lef58_keepoutzone_rule -> lef58_keepout_zone_rule
| auto first = s.begin(); | ||
| auto last = s.end(); | ||
| bool valid = qi::phrase_parse(first, last, LEF58_KEEPOUTZONE, space) | ||
| bool valid = qi::phrase_parse(first, last, lef58_keepoutzone_rule, space) |
Member
There was a problem hiding this comment.
lef58_keepoutzone_rule -> lef58_keepout_zone_rule
Signed-off-by: Divinesoumyadip <soumyacode7@gmail.com>
Divinesoumyadip
force-pushed
the
fix-2275-part2
branch
from
789795d to
933e5f2
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
eder-matheus
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on my previous PR #9702 and @maliberty's feedback, this PR continues the broader naming convention cleanup for issue #2275.
I have refactored the local
Boost.Spiritqi::rulevariables fromSCREAMING_SNAKE_CASEto standardsnake_casein the following parsers to comply with the Google C++ Style Guide:ArraySpacingParser.cppKeepOutZoneParser.cppAntennaGateParser.cppTesting:
Built successfully locally (
make).And ran the OpenDB test suite (ctest -R odb) and all 86/86 tests passed, confirming the parsers still map the LEF file strings correctly.