feat(headless): Implement ViewDummy

[bobtista]

Summary

• Adds ViewDummy class in Core/GameEngine/Include/GameClient/View.h with no-op implementations for headless mode
• Factory in W3DInGameUI returns dummy when m_headless is true
• Refactors InGameUI::init() to always create TheTacticalView, but only init/attach to display when TheDisplay exists
• Empty xfer() to skip view block in saves

Related

Split from #2139 per @xezon's suggestion to review each dummy class separately.

[greptile-apps]

Greptile Summary

This PR introduces ViewDummy, a no-op implementation of the View base class used when running in headless mode. InGameUI::init() is refactored to always allocate TheTacticalView (returning ViewDummy when TheGlobalData->m_headless is set), and the init/attachView/resize/setDefaultView steps are gated on TheDisplay being present. The createView() factory virtual is widened with a bool dummy parameter so W3DInGameUI can dispatch to the correct concrete type.

Key observations:

• The ViewDummy class correctly implements all pure-virtual methods from View, and deliberately does not override xfer() so the base serialization runs for save-file compatibility — the intent is documented with an inline comment.
• isDoingScriptedCamera() and stopDoingScriptedCamera() in ViewDummy are marked override, but neither method exists anywhere in the View base class. The C++ override specifier causes a hard compile-time error when no matching virtual is found in the base. These two methods should either have the override specifier removed (and the corresponding virtual declarations added to View), or be deleted entirely if headless mode has no scripted-camera behaviour.
• The same ViewDummy class is defined in Core/ and shared by both Generals/ and GeneralsMD/, which is the correct approach for avoiding duplication.

Confidence Score: 1/5

• Not safe to merge — ViewDummy contains invalid override specifiers that are hard compile errors in C++.
• The isDoingScriptedCamera() and stopDoingScriptedCamera() methods in ViewDummy carry the override specifier, but neither method is declared as virtual anywhere in the View base class. In standard C++, override on a method with no matching virtual in any base class is a compile-time error (not a warning), meaning the project will fail to build as-is. This single issue blocks the PR from merging.
• Core/GameEngine/Include/GameClient/View.h — the two invalid override declarations on lines 363–364 must be resolved before this can compile.

Important Files Changed

Filename	Overview
Core/GameEngine/Include/GameClient/View.h	Adds ViewDummy class to serve as a headless no-op view. Has outstanding compile errors: isDoingScriptedCamera() and stopDoingScriptedCamera() are marked override but neither method exists in the View base class.
Generals/Code/GameEngine/Source/GameClient/InGameUI.cpp	Refactors tactical view creation to always allocate TheTacticalView (via createView), then conditionally init/attach only when TheDisplay exists. setDefaultView moved inside the display guard. TheGlobalData is already assumed non-null throughout this function.
GeneralsMD/Code/GameEngine/Source/GameClient/InGameUI.cpp	Mirror of Generals InGameUI.cpp changes — same refactoring for tactical view creation in Zero Hour. No distinct issues beyond those in the Generals copy.
Generals/Code/GameEngineDevice/Include/W3DDevice/GameClient/W3DInGameUI.h	createView() factory refactored to accept a bool dummy parameter and dispatch to ViewDummy or W3DView accordingly. TheGlobalData access correctly moved to the caller (InGameUI::init).
GeneralsMD/Code/GameEngineDevice/Include/W3DDevice/GameClient/W3DInGameUI.h	Identical change to the Generals W3DInGameUI.h — same dummy-dispatch factory pattern, same assessment.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["InGameUI::init()"] --> B["createView(TheGlobalData->m_headless)"]
    B --> C{dummy == true?}
    C -- Yes --> D["new ViewDummy\n(no-op headless view)"]
    C -- No --> E["new W3DView\n(full rendering view)"]
    D --> F["TheTacticalView = view"]
    E --> F
    F --> G{TheTacticalView &&\nTheDisplay?}
    G -- No --> H["Skip display init\n(headless path)"]
    G -- Yes --> I["TheTacticalView->init()"]
    I --> J["TheDisplay->attachView(TheTacticalView)"]
    J --> K["setWidth / setHeight"]
    K --> L["setDefaultView(0,0,1)"]

Loading

_{Last reviewed commit: "refactor(headless): ..."}

[greptile-apps]

_{5 files reviewed, 5 comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

_{5 files reviewed, 5 comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

_{5 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

_{5 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

[xezon]

has left over comments

[xezon]

OK