feat(gui): Add minimize button to game window in windowed mode#2473
Open
Caball009 wants to merge 1 commit intoTheSuperHackers:mainfrom
Open
feat(gui): Add minimize button to game window in windowed mode#2473Caball009 wants to merge 1 commit intoTheSuperHackers:mainfrom
Caball009 wants to merge 1 commit intoTheSuperHackers:mainfrom
Conversation
|
| Filename | Overview |
|---|---|
| GeneralsMD/Code/Main/WinMain.cpp | Adds WS_MINIMIZEBOX to the windowed-mode window style flags so users get a functional minimize button on the title bar; no other logic is touched. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[initializeAppWindows] --> B["windowStyle = WS_POPUP | WS_VISIBLE"]
B --> C{runWindowed?}
C -- Yes --> D["windowStyle |= WS_MINIMIZEBOX | WS_SYSMENU | WS_DLGFRAME | WS_CAPTION"]
C -- No --> E["windowStyle |= WS_EX_TOPMOST | WS_SYSMENU"]
D --> F[AdjustWindowRect]
E --> F
F --> G[CreateWindow with computed style]
G --> H[Windowed window WITH minimize button]
G --> H2[Fullscreen popup window]
Last reviewed commit: "feat(gui): Add minim..."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the minimize button to the game window when the game is in windowed mode.
TODO: