[KernelCache] Set region display names#8267
Closed
jonpalmisc wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Unlike my last meme PR this one is actually of great importance to me. Will offer bribes to merge if necessary. |
bdash
reviewed
Jun 16, 2026
| auto fillRegion = memoryMap->GetActiveMemoryRegionAt(fillStart); | ||
|
|
||
| if (!fillRegion.empty() && fillRegion != region) | ||
| memoryMap->SetMemoryRegionDisplayName(fillRegion, displayName + "$ZEROFILL"); |
Contributor
There was a problem hiding this comment.
I'd suggest taking inspiration from MachoView for the naming of the zero filled portion:
binaryninja-api/view/macho/machoview.cpp
Lines 1848 to 1851 in cbab54c
This makes it easier to obtain the bounds of segments and mirrors the functionality of the shared cache support.
jonpalmisc
force-pushed
the
kc_region_display_name
branch
from
60a73f8 to
f651f7c
Compare
Contributor
|
Rebased + merged to dev in e2bcf29. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty self-explanatory. Only bit I'm unsure of is the nomenclature for zerofill gaps (
$ZEROFILLsuffix currently), or whether they should be even labeled at all.Let me know if/what you want changed.