Skip to content

[KernelCache] Set region display names #8267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonpalmisc wants to merge 1 commit into from
+20 −0
Closed

[KernelCache] Set region display names #8267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions view/kernelcache/core/KernelCacheController.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ bool KernelCacheController::ApplyImage(BinaryView& view, const CacheImage& image
if (!view.IsValidOffset(image.headerVirtualAddress))
{
loadedRegion = true;
auto memoryMap = view.GetMemoryMap();
for (const auto& segment : image.header->segments)
{
if (segment.vmsize == 0)
Expand All @@ -130,6 +131,25 @@ bool KernelCacheController::ApplyImage(BinaryView& view, const CacheImage& image
auto flags = SegmentFlagsForSegment(segment);
view.AddAutoSegment(segment.vmaddr, segment.vmsize, segment.fileoff, segment.filesize, flags);

if (memoryMap)
{
std::string segmentName(segment.segname, std::find(segment.segname, std::end(segment.segname), '\0'));
std::string displayName = image.GetName() + "::" + segmentName;

auto region = memoryMap->GetActiveMemoryRegionAt(segment.vmaddr);
if (!region.empty())
memoryMap->SetMemoryRegionDisplayName(region, displayName);

if (segment.vmsize != segment.filesize)
{
auto fillStart = segment.vmaddr + segment.filesize;
auto fillRegion = memoryMap->GetActiveMemoryRegionAt(fillStart);

if (!fillRegion.empty() && fillRegion != region)
memoryMap->SetMemoryRegionDisplayName(fillRegion, displayName + " (zero fill)");
}
}

const auto& relocations = m_cache.GetRelocations();

auto begin = std::lower_bound(relocations.begin(), relocations.end(), segment.vmaddr,
Expand Down