Conversation
The Casks/nssh.rb that goreleaser pushed for v2.4.1 fails `brew test-bot` with two RuboCop offenses: - Style/IfUnlessModifier on the `if OS.mac?` postflight block — fixed by rewriting it as a modifier-if. The guard is still needed because the cask has on_linux URL stanzas, so postflight can theoretically run on linuxbrew where /usr/bin/xattr doesn't exist. - Layout/EmptyLinesAroundBlockBody on the trailing blank before the cask's closing `end`. That blank is from goreleaser's template emitting `# No zap stanza required\n\n` when no zap is configured. Adding a real zap stanza replaces the placeholder. The paths chosen (~/.local/state/nssh, ~/.config/nssh) match what nssh actually writes on the local Mac (logs, session state, optional config.toml). Cut a v2.4.2 release after this merges to regenerate Casks/nssh.rb and clear the red status on abizer/homebrew-tap master. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Zap stanza missing
~/.cache/nsshcleanup path- Added
~/.cache/nsshto the cask zap.trash list sobrew uninstall --zapcleans up the local release tarball cache.
- Added
Or push these changes by commenting:
@cursor push 99ae82d1b4
Preview (99ae82d1b4)
diff --git a/.goreleaser.yaml b/.goreleaser.yaml
--- a/.goreleaser.yaml
+++ b/.goreleaser.yaml
@@ -51,6 +51,7 @@
trash:
- "~/.local/state/nssh"
- "~/.config/nssh"
+ - "~/.cache/nssh"
release:
github:You can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit f88fc8b. Configure here.
| zap: | ||
| trash: | ||
| - "~/.local/state/nssh" | ||
| - "~/.config/nssh" |
There was a problem hiding this comment.
Zap stanza missing ~/.cache/nssh cleanup path
Low Severity
The zap.trash stanza in the Homebrew formula is missing ~/.cache/nssh. This directory, created by downloadBinary in infect.go for caching release tarballs (e.g., ~/.cache/nssh/releases/), remains after brew uninstall --zap, allowing cached files to accumulate.
Reviewed by Cursor Bugbot for commit f88fc8b. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`brew test-bot` is failing on `abizer/homebrew-tap` master (run 25410956395) because the v2.4.1-generated `Casks/nssh.rb` has two RuboCop offenses:
/.local/state/nssh`, `/.config/nssh`).Test plan
🤖 Generated with Claude Code
Note
Low Risk
Low risk: only adjusts GoReleaser Homebrew cask generation to satisfy
brew style, without changing app runtime behavior beyond uninstall cleanup metadata.Overview
Updates
.goreleaser.yamlto change the generated Homebrew cask: the post-install quarantine removal hook is rewritten as a single-line modifierif OS.mac?to satisfy RuboCop.Adds an explicit
zap.trashsection (listing~/.local/state/nsshand~/.config/nssh) to avoid GoReleaser emitting the# No zap stanza requiredplaceholder that was causingbrew styleempty-line violations.Reviewed by Cursor Bugbot for commit f88fc8b. Bugbot is set up for automated code reviews on this repo. Configure here.