Skip to content

ci: fix brew style violations in generated cask #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abizer merged 1 commit into from
May 6, 2026
+8 −3
Merged

ci: fix brew style violations in generated cask #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .goreleaser.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,14 @@ homebrew_casks:
hooks:
post:
install: |
if OS.mac?
system_command "/usr/bin/xattr", args: ["-dr", "com.apple.quarantine", "#{staged_path}/nssh"]
end
system_command "/usr/bin/xattr", args: ["-dr", "com.apple.quarantine", "#{staged_path}/nssh"] if OS.mac?
# Populate the zap stanza so goreleaser's template doesn't emit a
# `# No zap stanza required` placeholder with a trailing blank line
# that trips Layout/EmptyLinesAroundBlockBody under `brew style`.
zap:
trash:
- "~/.local/state/nssh"
- "~/.config/nssh"
Copy link
Copy Markdown

@cursor cursor Bot May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zap stanza missing ~/.cache/nssh cleanup path

Low Severity

The zap.trash stanza in the Homebrew formula is missing ~/.cache/nssh. This directory, created by downloadBinary in infect.go for caching release tarballs (e.g., ~/.cache/nssh/releases/), remains after brew uninstall --zap, allowing cached files to accumulate.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit f88fc8b. Configure here.


release:
github:
Expand Down