Skip to content

ci: GitHub Actions workflow security cleanup #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emptyhammond wants to merge 3 commits into
base: main
Choose a base branch
from
+33 −12
Open

ci: GitHub Actions workflow security cleanup #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
395102b
ci: disable credential persistence on checkout
emptyhammond May 26, 2026
367c84b
ci: scope GITHUB_TOKEN permissions per job
emptyhammond May 26, 2026
c8a9c07
ci: pin third-party actions to commit SHAs
emptyhammond May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/assemble.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,25 @@ on:
branches:
- main

permissions: {}

jobs:
build:
runs-on: ubuntu-latest
permissions:
contents: read
deployments: write
id-token: write
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
with:
persist-credentials: false

- name: Read Tool Versions
id: tool-versions
run: echo "::set-output name=nodejs::$(sed -nr 's/nodejs ([0-9]+)/\1/p' .tool-versions)"

- uses: actions/setup-node@v3
- uses: actions/setup-node@3235b876344d2a9aa001b8d1453c930bba69e610 # v3
with:
node-version: ${{ steps.tool-versions.outputs.nodejs }}

Expand All @@ -38,13 +43,13 @@ jobs:
- name: Configure AWS Credentials
# at some point AWS will release a `v2` of this action. See:
# https://github.com/aws-actions/configure-aws-credentials/issues/489#issuecomment-1278145876
uses: aws-actions/configure-aws-credentials@v1-node16
uses: aws-actions/configure-aws-credentials@e1e17a757e536f70e52b5a12b2e8d1d1c60e04ef # v1-node16
with:
aws-region: eu-west-2
role-to-assume: arn:aws:iam::${{ secrets.ABLY_AWS_ACCOUNT_ID_SDK }}:role/ably-sdk-builds-features
role-session-name: "${{ github.run_id }}-${{ github.run_number }}"

- uses: ably/sdk-upload-action@v2
- uses: ably/sdk-upload-action@4e694297f208b72b5a9f6b1248a1556f19f821d6 # v2
with:
sourcePath: render/output
githubToken: ${{ secrets.GITHUB_TOKEN }}
Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,23 @@ on:
branches:
- main

permissions: {}

jobs:
check:
runs-on: ubuntu-latest
permissions:
contents: read
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
with:
persist-credentials: false

- name: Read Tool Versions
id: tool-versions
run: echo "::set-output name=nodejs::$(sed -nr 's/nodejs ([0-9]+)/\1/p' .tool-versions)"

- uses: actions/setup-node@v3
- uses: actions/setup-node@3235b876344d2a9aa001b8d1453c930bba69e610 # v3
with:
node-version: ${{ steps.tool-versions.outputs.nodejs }}

Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/publish-core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,23 @@ name: Publish Core
on:
workflow_dispatch:

permissions: {}

jobs:
build:
runs-on: ubuntu-latest
permissions:
contents: read
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
with:
persist-credentials: false

- name: Read Tool Versions
id: tool-versions
run: echo "::set-output name=nodejs::$(sed -nr 's/nodejs ([0-9]+)/\1/p' .tool-versions)"

- uses: actions/setup-node@v3
- uses: actions/setup-node@3235b876344d2a9aa001b8d1453c930bba69e610 # v3
with:
node-version: ${{ steps.tool-versions.outputs.nodejs }}
registry-url: https://registry.npmjs.org/
Expand Down
12 changes: 8 additions & 4 deletions .github/workflows/sdk-features.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,30 +13,34 @@ on:
ABLY_AWS_ACCOUNT_ID_SDK:
required: true

permissions: {}

jobs:
build:
runs-on: ubuntu-latest
permissions:
contents: read
deployments: write
id-token: write
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
with:
submodules: 'recursive'
persist-credentials: false

- uses: ably/features-action@v1
- uses: ably/features-action@ff8a5737341795275572b1c6ce37d9169a7b564a # v1
id: features

- name: Configure AWS Credentials
# at some point AWS will release a `v2` of this action. See:
# https://github.com/aws-actions/configure-aws-credentials/issues/489#issuecomment-1278145876
uses: aws-actions/configure-aws-credentials@v1-node16
uses: aws-actions/configure-aws-credentials@e1e17a757e536f70e52b5a12b2e8d1d1c60e04ef # v1-node16
with:
aws-region: eu-west-2
role-to-assume: arn:aws:iam::${{ secrets.ABLY_AWS_ACCOUNT_ID_SDK }}:role/ably-sdk-builds-${{ inputs.repository-name }}
role-session-name: "${{ github.run_id }}-${{ github.run_number }}"

- uses: ably/sdk-upload-action@v2
- uses: ably/sdk-upload-action@4e694297f208b72b5a9f6b1248a1556f19f821d6 # v2
with:
sourcePath: ${{ steps.features.outputs.matrix-path }}
githubToken: ${{ secrets.GITHUB_TOKEN }}
Expand Down
Loading