fix: drop getAsString from HeadContext
#41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for impala-react-ts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for impala-react-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for impala-preact-ts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for impala-preact-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Merged
ascorbic
pushed a commit
that referenced
this pull request
Oct 13, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>preact: 0.0.15</summary> ## [0.0.15](preact-v0.0.14...preact-v0.0.15) (2025-10-13) ### Bug Fixes * drop `getAsString` from `HeadContext` ([#41](#41)) ([407e9b6](407e9b6)) </details> <details><summary>react: 0.0.15</summary> ## [0.0.15](react-v0.0.14...react-v0.0.15) (2025-10-13) ### Bug Fixes * drop `getAsString` from `HeadContext` ([#41](#41)) ([407e9b6](407e9b6)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: mixie-bot[bot] <127146692+mixie-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ascorbic Is Impala still maintained? I happened to have some small projects that
@impala/preactjust perfectly fit the need.I noticed that
preact-render-to-stringis being included in the client bundle, which is weird. I dug around and noticed that this is used in theHeadContext'sgetAsStringmethod, which is not being used at all: https://github.com/search?q=repo%3Aascorbic%2Fimpala%20getAsString&type=codeI guess the
getAsStringwas added for SSR, but later the SSR for<head />has been moved toentry-serverinstead, which madegetAsStringobsolete:impala/packages/preact/src/entry-server.tsx
Line 25 in 74a4ab0
impala/packages/react/src/entry-server.tsx
Line 60 in 74a4ab0
The PR removes the
getAsStringmethod fromHeadContext, preventingpreact-render-to-stringandreact-dom/serverfrom being included in the client bundle (they should only be in the server bundle).