Skip to content

fix: drop getAsString from HeadContext #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ascorbic merged 1 commit into from
Oct 13, 2025
Merged

fix: drop getAsString from HeadContext #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/preact/src/head-context.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { createContext, VNode } from "preact";
import render from "preact-render-to-string";

class HeadProvider {
private head: VNode<any>[] = [];
Expand Down Expand Up @@ -30,10 +29,6 @@ class HeadProvider {
public getHead() {
return this.head;
}

public getAsString() {
return render(<>{...this.head}</>);
}
}

const headProvider = new HeadProvider();
Expand Down
5 changes: 0 additions & 5 deletions packages/react/src/head-context.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import React, { createContext, ReactElement, ReactNode } from "react";
import { renderToStaticMarkup } from "react-dom/server";

class HeadProvider {
private head: React.ReactElement[] = [];
Expand Down Expand Up @@ -30,10 +29,6 @@ class HeadProvider {
public getHead() {
return this.head;
}

public getAsString() {
return renderToStaticMarkup(<>{...this.head}</>);
}
}

const headProvider = new HeadProvider();
Expand Down