Skip to content

Change FontHinting::should_hint to pub#23397

Merged
mockersf merged 4 commits intobevyengine:mainfrom
ickshonpe:pub-fonthinting-should_hint
Mar 17, 2026
Merged

Change FontHinting::should_hint to pub#23397
mockersf merged 4 commits intobevyengine:mainfrom
ickshonpe:pub-fonthinting-should_hint

Conversation

@ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Mar 17, 2026

Objective

  • A trivial helper function like FontHinting::should_hint should be pub if it exists.
  • should_hint doesn't seem very idiomatic and doesn't match the names of the enum's variants.

Solution

  • Renamed FontHinting::should_hint to is_enabled.
  • Changed FontHinting::is_enabled from pub(crate) to pub.
  • Added the required doc comment now its public.

@ickshonpe ickshonpe added A-Text Rendering and layout for characters D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Mar 17, 2026
@ickshonpe ickshonpe changed the title Made the FontHinting::should_hint method pub. Change FontHinting::should_hint to pub Mar 17, 2026
@kfc35 kfc35 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 17, 2026
Co-authored-by: Kevin Chen <chen.kevin.f@gmail.com>
@mockersf mockersf added this pull request to the merge queue Mar 17, 2026
Merged via the queue into bevyengine:main with commit 0cef5fa Mar 17, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Text Rendering and layout for characters C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants