Skip to content

Downgrade gpu_readback closed-channel log from warn to debug#24707

Merged
alice-i-cecile merged 1 commit into
bevyengine:mainfrom
PeteMichaud:readback-debug-log
Jun 22, 2026
Merged

Downgrade gpu_readback closed-channel log from warn to debug#24707
alice-i-cecile merged 1 commit into
bevyengine:mainfrom
PeteMichaud:readback-debug-log

Conversation

@PeteMichaud

Copy link
Copy Markdown
Contributor

map_async callbacks in map_buffers fire during wgpu's shutdown device-poll, after GpuReadbacks (which owns the channel receivers) has already been dropped. The try_send fails with Closed — expected, since the consumer is gone because the app is exiting. The same happens when a Readback entity is intentionally despawned.

This produces two WARN bevy_render::gpu_readback: Failed to send readback result: ... lines on every app exit for any app using Readback. The warning is never actionable.

Downgrade to debug! so the message is still available for diagnosis but doesn't pollute default log output.

@github-actions

Copy link
Copy Markdown
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide, as well as our policy regarding AI usage, and we look forward to reviewing your pull request shortly ✨

@PeteMichaud

Copy link
Copy Markdown
Contributor Author

Context for me here is that I wanted to stop this from spamming my console and I realized that it was either a tiny change here that I believe everyone who uses readback would want, or some huge song and dance of forking or vendoring just this or something crazy.

@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jun 22, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in Rendering Jun 22, 2026
@alice-i-cecile

Copy link
Copy Markdown
Member

Context for me here is that I wanted to stop this from spamming my console and I realized that it was either a tiny change here that I believe everyone who uses readback would want, or some huge song and dance of forking or vendoring just this or something crazy.

FYI you can filter logs :) Still, I agree with this downgrade!

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 22, 2026
Merged via the queue into bevyengine:main with commit b4aae57 Jun 22, 2026
47 checks passed
@github-project-automation github-project-automation Bot moved this from Needs SME Triage to Done in Rendering Jun 22, 2026
@IceSentry

Copy link
Copy Markdown
Contributor

That should have probably been trace, not debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants