Skip to content

Add missing import for light probe const ..._LIGHTMAPPED_MESH_DIFFUSE in irradiance_volume.wgsl#24714

Merged
alice-i-cecile merged 1 commit into
bevyengine:mainfrom
kfc35:add_missing_import
Jun 22, 2026
Merged

Add missing import for light probe const ..._LIGHTMAPPED_MESH_DIFFUSE in irradiance_volume.wgsl#24714
alice-i-cecile merged 1 commit into
bevyengine:mainfrom
kfc35:add_missing_import

Conversation

@kfc35

@kfc35 kfc35 commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Objective

Solution

  • Import the missing const

Testing

  • This is simple to verify by eye so I didn’t test this myself
  • However, this just reminds me that there needs to be more automated testing for rendering to discover such defects.

@kfc35 kfc35 added C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 22, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in Rendering Jun 22, 2026
@kfc35 kfc35 added this to the 0.19.1 milestone Jun 22, 2026
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 22, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 22, 2026
Merged via the queue into bevyengine:main with commit 2442e91 Jun 22, 2026
49 checks passed
@github-project-automation github-project-automation Bot moved this from Needs SME Triage to Done in Rendering Jun 22, 2026
@Noxmore Noxmore mentioned this pull request Jun 22, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Rendering
Status: Done

Milestone

0.19.1

Development

Successfully merging this pull request may close these issues.

2 participants

@kfc35 @alice-i-cecile