Skip to content

Throw friendly error when listing install fails#3952

Open
lucaslyl wants to merge 2 commits intomainfrom
ECO-466-display-a-error-message-ui-whenever-a-remix-run-fails
Open

Throw friendly error when listing install fails#3952
lucaslyl wants to merge 2 commits intomainfrom
ECO-466-display-a-error-message-ui-whenever-a-remix-run-fails

Conversation

@lucaslyl
Copy link
Contributor

@lucaslyl lucaslyl commented Feb 5, 2026

linear: https://linear.app/cardstack/issue/ECO-466/display-a-error-message-ui-whenever-a-remix-run-fails

Result:

Before:
image

After:

Screen.Recording.2026-02-05.at.4.10.24.PM.mov

@lucaslyl lucaslyl self-assigned this Feb 5, 2026
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Preview deployments

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Host Test Results

    1 files  ±0      1 suites  ±0   1h 48m 17s ⏱️ + 3m 50s
1 944 tests ±0  1 927 ✅ +13  17 💤 ±0  0 ❌ ± 0 
1 959 runs  ±0  1 942 ✅ +26  17 💤 ±0  0 ❌  - 13 

Results for commit cf074d7. ± Comparison against base commit cf3abb2.

♻️ This comment has been updated with latest results.

@lucaslyl lucaslyl requested a review from a team February 5, 2026 08:43
throw new Error(
detail
? `Please make sure your listing has all required specs linked. ${detail}`
: 'Please make sure your listing has all required specs linked',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • check condition filter is of non-existent type
    • if true, return suggestion to "click on update specs" and/or "make sure all specs are linked"
    • if false, fallback to detail

Copy link
Contributor

@tintinthong tintinthong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added commment

@lucaslyl lucaslyl requested a review from tintinthong February 6, 2026 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants