Skip to content

Throw friendly error when listing install fails #3952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucaslyl wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Throw friendly error when listing install fails #3952

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b74bfb4
Throw friendly error when listing install fails
lucaslyl Feb 5, 2026
cf074d7
update err message
lucaslyl Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/host/app/commands/listing-install.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,18 @@ export default class ListingInstallCommand extends HostBaseCommand<
new URL(realmUrl),
);

let atomicResults: AtomicOperationResult[] = results['atomic:results'];
let atomicResults: AtomicOperationResult[] | undefined =
results['atomic:results'];
if (!Array.isArray(atomicResults)) {
let detail = (results as { errors?: Array<{ detail?: string }> })
.errors?.[0]?.detail;
if (detail?.includes('filter refers to a nonexistent type')) {
throw new Error(
'Please click "Update Specs" on the listing and make sure all specs are linked.',
);
}
throw new Error(detail);
}
let writtenFiles = atomicResults.map((r) => r.data.id);
log.debug('=== Final Results ===');
log.debug(JSON.stringify(writtenFiles, null, 2));
Expand Down