Skip to content

Bump libntech to latest#6187

Merged
craigcomstock merged 3 commits into
cfengine:masterfrom
craigcomstock:ent-14143
Jun 25, 2026
Merged

Bump libntech to latest#6187
craigcomstock merged 3 commits into
cfengine:masterfrom
craigcomstock:ent-14143

Conversation

@craigcomstock

Copy link
Copy Markdown
Contributor

Needed for fixes related to ENT-14143

Ticket: ENT-14143
Changelog: none

@craigcomstock craigcomstock force-pushed the ent-14143 branch 3 times, most recently from 329301e to b8e8964 Compare June 24, 2026 15:11
@cfengine cfengine deleted a comment from cf-bottom Jun 24, 2026
Needed for fixes related to ENT-14143

Ticket: ENT-14143
Changelog: none
This will catch more warnings as errors and help us keep our code cleaner.

Ticket: ENT-14208
Changelog: none
@olehermanse

Copy link
Copy Markdown
Member

@cf-bottom jenkins, please

@cf-bottom

Copy link
Copy Markdown

Comment thread libpromises/evalfunction.c Fixed
Comment thread libpromises/syslog_client.c Fixed
Comment thread libpromises/syslog_client.c Fixed
@craigcomstock craigcomstock force-pushed the ent-14143 branch 3 times, most recently from 2bdb7d8 to 326f00a Compare June 24, 2026 16:18
@craigcomstock

Copy link
Copy Markdown
Contributor Author

valgrind check failed with

error: Failed to establish TLS connection: underlying network error (Connection reset by peer)

I will test this manually and see if I can reproduce. Maybe one of the VLA fixes broke something.

@craigcomstock craigcomstock marked this pull request as draft June 24, 2026 18:38
While VLAs are supported in C99 and C11, they do pose some portability issues so best to avoid their use.

alloca() allocates on the stack frame and is free'd on exit from the function so essentially equivalent.

Ticket: ENT-14208
Changelog: none
@craigcomstock craigcomstock marked this pull request as ready for review June 24, 2026 18:52
@craigcomstock

Copy link
Copy Markdown
Contributor Author

@cf-bottom jenkins please

@cf-bottom

Copy link
Copy Markdown

@craigcomstock craigcomstock merged commit f8363f5 into cfengine:master Jun 25, 2026
43 checks passed
@craigcomstock craigcomstock deleted the ent-14143 branch June 25, 2026 11:50
@craigcomstock craigcomstock added cherry-pick? Fixes which may need to be cherry-picked to LTS branches and removed cherry-pick? Fixes which may need to be cherry-picked to LTS branches labels Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants