Skip to content

Bump libntech to latest #6187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
craigcomstock merged 3 commits into from
Jun 25, 2026
Merged

Bump libntech to latest #6187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3423caf
Bump libntech to latest
craigcomstock Jun 24, 2026
7544e66
Added -Wextra and -Wno-sign-compare to github workflow gcc options
craigcomstock Jun 24, 2026
6e95201
Refactored variable length array code to use alloca()
craigcomstock Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/asan_unit_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ jobs:
- name: Run autotools / configure
run: ./autogen.sh --enable-debug
- name: Compile and link (make)
run: make -j8 CFLAGS="-Werror -Wall -fsanitize=address" LDFLAGS="-fsanitize=address"
run: make -j8 CFLAGS="-Werror -Wall -Wextra -Wno-sign-compare -fsanitize=address" LDFLAGS="-fsanitize=address"
- name: Run unit tests
run: make -C tests/unit CFLAGS="-fsanitize=address" LDFLAGS="-fsanitize=address" check
2 changes: 1 addition & 1 deletion .github/workflows/macos_unit_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@ jobs:
run: >
./autogen.sh --enable-debug
- name: Compile and link
run: MACOSX_DEPLOYMENT_TARGET=15.4 make -j8 CFLAGS="-Werror -Wall"
run: MACOSX_DEPLOYMENT_TARGET=15.4 make -j8 CFLAGS="-Werror -Wall -Wextra -Wno-sign-compare"
- name: Run unit tests
run: make -C tests/unit check
2 changes: 1 addition & 1 deletion .github/workflows/unit_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ jobs:
- name: Run autotools / configure
run: ./autogen.sh --enable-debug
- name: Compile and link (make)
run: make -j8 CFLAGS="-Werror -Wall"
run: make -j8 CFLAGS="-Werror -Wall -Wextra -Wno-sign-compare"
- name: Run unit tests
run: make -C tests/unit check
4 changes: 2 additions & 2 deletions cf-serverd/server_tls.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,8 @@ bool ServerTLSPeek(ConnectionInfo *conn_info)

const int peek_size = CF_INBAND_OFFSET + sizeof("CAUTH");

char buf[peek_size];
ssize_t got = recv(ConnectionInfoSocket(conn_info), buf, sizeof(buf), MSG_PEEK);
char *buf = alloca(peek_size);
ssize_t got = recv(ConnectionInfoSocket(conn_info), buf, peek_size, MSG_PEEK);
assert(got <= peek_size);
if (got < 0)
{
Expand Down
2 changes: 1 addition & 1 deletion libntech
Open in desktop
Submodule libntech updated 7 files
+1 −1 .github/workflows/asan_unit_tests.yml
+1 −1 .github/workflows/macos_unit_tests.yml
+1 −1 .github/workflows/unit_tests.yml
+2 −1 libutils/json.c
+2 −2 libutils/string_lib.c
+1 −1 libutils/unix_dir.c
+54 −1 tests/unit/string_lib_test.c
5 changes: 2 additions & 3 deletions libpromises/evalfunction.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8533,9 +8533,8 @@ static FnCallResult FnCallClassFilterCsv(EvalContext *ctx,
}
else
{
size_t const key_len = PRINTSIZE(size_t);
char key[key_len];
xsnprintf(key, key_len, "%zu", i);
char key[PRINTSIZE(size_t)];
xsnprintf(key, PRINTSIZE(size_t), "%zu", i);

JsonObjectAppendString(class_container,
key,
Expand Down
2 changes: 1 addition & 1 deletion libpromises/ornaments.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ void PromiseBanner(EvalContext *ctx, const Promise *pp)
}

const size_t n = 2*CF_MAXFRAGMENT + 3;
char pretty_promise_name[n+1];
char *pretty_promise_name = alloca(n+1);
pretty_promise_name[0] = '\0';
StringAppendAbbreviatedPromise(pretty_promise_name, pp->promiser, n, CF_MAXFRAGMENT);
Log(LOG_LEVEL_VERBOSE, "P: Promiser/affected object: '%s'", pretty_promise_name);
Expand Down
5 changes: 3 additions & 2 deletions libpromises/syslog_client.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@

#include <cf3.defs.h>


#define RFC3164_LENGTH 1024
/*
* Set by cf-agent/cf-serverd from body agent/server control.
*/
Expand Down Expand Up @@ -112,8 +114,7 @@ void RemoteSysLog(int log_priority, const char *log_string)
}
else
{
const size_t rfc3164_len = 1024;
char message[rfc3164_len];
char message[RFC3164_LENGTH];
char timebuffer[26];
pid_t pid = getpid();

Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/mock_package_manager.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
static char AVAILABLE_PACKAGES_FILE_NAME[PATH_MAX];
static char INSTALLED_PACKAGES_FILE_NAME[PATH_MAX];

static const int MAX_PACKAGE_ENTRY_LENGTH = 256;
#define MAX_PACKAGE_ENTRY_LENGTH 256

#define DEFAULT_ARCHITECTURE "x666"

Expand Down
Loading