Skip to content

chore: add formatter#100

Open
marcalexiei wants to merge 1 commit intochangesets:masterfrom
marcalexiei:format
Open

chore: add formatter#100
marcalexiei wants to merge 1 commit intochangesets:masterfrom
marcalexiei:format

Conversation

@marcalexiei
Copy link
Copy Markdown
Contributor

@marcalexiei marcalexiei commented Mar 30, 2026


  • Add oxfmt as formatter
  • Apply format to source code
  • Add format:check script run on ci.yml

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 30, 2026

@marcalexiei is attempting to deploy a commit to the Changesets Team on Vercel.

A member of the Team first needs to authorize it.

@Andarist
Copy link
Copy Markdown
Member

@marcalexiei could you rebase this now? Let's see if the CI checks actually work now :p

@marcalexiei marcalexiei marked this pull request as ready for review March 31, 2026 22:53
@marcalexiei marcalexiei requested a review from emmatown as a code owner March 31, 2026 22:53
Copy link
Copy Markdown
Contributor Author

@marcalexiei marcalexiei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you rebase this now?

Done, this PR is now in sync with master


Let's see if the CI checks actually work now :p

Everything works as expected!
I saw few warnings in the PR CI run and I've created separate threads to discuss them.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

> warning " > vitest@4.1.2" has incorrect peer dependency "vite@^6.0.0 || ^7.0.0 || ^8.0.0".

Likely caused by

bot/package.json

Lines 39 to 41 in be84759

"resolutions": {
"vite": "npm:vite@8.0.0-beta.18"
},

Can we install vite latest version (8.0.3) to remove it or there is a particular reason to use this beta?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

> warning "vite > rolldown > @rolldown/binding-wasm32-wasi > @napi-rs/wasm-runtime@1.1.2" has unmet peer dependency "@emnapi/core@^1.7.1".
> warning "vite > rolldown > @rolldown/binding-wasm32-wasi > @napi-rs/wasm-runtime@1.1.2" has unmet peer dependency "@emnapi/runtime@^1.7.1".

I don’t believe these warnings are an issue, since we’re only using vite indirectly via vitest, and the tests are running without problems.

If we want to eliminate the warnings, we could install the missing peer dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants