Conversation
|
@marcalexiei is attempting to deploy a commit to the Changesets Team on Vercel. A member of the Team first needs to authorize it. |
|
@marcalexiei could you rebase this now? Let's see if the CI checks actually work now :p |
marcalexiei
left a comment
There was a problem hiding this comment.
could you rebase this now?
Done, this PR is now in sync with master
Let's see if the CI checks actually work now :p
Everything works as expected!
I saw few warnings in the PR CI run and I've created separate threads to discuss them.
There was a problem hiding this comment.
> warning " > vitest@4.1.2" has incorrect peer dependency "vite@^6.0.0 || ^7.0.0 || ^8.0.0".
Likely caused by
Lines 39 to 41 in be84759
Can we install vite latest version (8.0.3) to remove it or there is a particular reason to use this beta?
There was a problem hiding this comment.
> warning "vite > rolldown > @rolldown/binding-wasm32-wasi > @napi-rs/wasm-runtime@1.1.2" has unmet peer dependency "@emnapi/core@^1.7.1".
> warning "vite > rolldown > @rolldown/binding-wasm32-wasi > @napi-rs/wasm-runtime@1.1.2" has unmet peer dependency "@emnapi/runtime@^1.7.1".
I don’t believe these warnings are an issue, since we’re only using vite indirectly via vitest, and the tests are running without problems.
If we want to eliminate the warnings, we could install the missing peer dependencies.
oxfmtas formatterformat:checkscript run onci.yml