RFC 017 aggregate modifiers#45
Draft
dannymeijer wants to merge 4 commits into
Draft
Conversation
This was referenced May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AggregateMeasure.distinct(),.filter(...), and.order_by(...)state.count_distinct(expr)andcount_if(predicate)compatibility helpers as decorator-registered aggregate rewrites.origin/mainafter RFC 016/018/024 wave 1 function catalog foundations #44 and removed the same redundant-helper/source-quality smells found during the RFC 016/018/024 wave 1 function catalog foundations #44 review loop.Merge Order
#44 has been merged. This PR now targets
maindirectly and can be reviewed as the RFC 017 follow-up.Verification
make fmt INCAN=/Users/danny/Development/encero/incan/target/debug/incan/Users/danny/Development/encero/incan/target/debug/incan test tests/test_function_registry.incn/Users/danny/Development/encero/incan/target/debug/incan test tests/test_substrait_plan.incn/Users/danny/Development/encero/incan/target/debug/incan test tests/test_session_aggregates.incn/Users/danny/Development/encero/incan/target/debug/incan test tests/test_dataset.incn/Users/danny/Development/encero/incan/target/debug/incan test src/functions/aggregatesmake pre-commit INCAN=/Users/danny/Development/encero/incan/target/debug/incanCloses #34