fix(vm): patch kvvm.spec.template.metadata on VM metadata changes #1971
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardcoretime
force-pushed
the
fix/vm/sync-kvvm-spec-labels
branch
2 times, most recently
from
3cad89b to
392fe0d
Compare
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
hardcoretime
force-pushed
the
fix/vm/sync-kvvm-spec-labels
branch
from
392fe0d to
7bf2d0d
Compare
hardcoretime
changed the title
hardcoretime
requested review from
Isteb4k and
yaroslavborbat
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
KubeVirt virtual machine spec template metadata labels and annotations are patched by the SyncMetadataHandler when a Deckhouse virtual machine updates its labels and annotations.
Why do we need it, and what problem does it solve?
This change is required to resolve the problem where KubeVirt virtual machine instances and their pods may restore their labels and annotations in some cases, even after these have been deleted from the Deckhouse virtual machine metadata.
What is the expected result?
The SyncMetadataHandler should properly synchronize labels and annotations.
Checklist
Changelog entries