Skip to content

fix(vm): patch kvvm.spec.template.metadata on VM metadata changes #1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hardcoretime wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

fix(vm): patch kvvm.spec.template.metadata on VM metadata changes #1971

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions images/virtualization-artifact/pkg/controller/vm/internal/sync_metadata.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,10 +139,22 @@ func (h *SyncMetadataHandler) patchLabelsAndAnnotations(ctx context.Context, obj
patch.NewJSONPatchOperation(patch.PatchReplaceOp, "/metadata/labels", metadata.Labels),
patch.NewJSONPatchOperation(patch.PatchReplaceOp, "/metadata/annotations", metadata.Annotations),
)

// For KubeVirt VirtualMachine, also patch spec.template.metadata
// to ensure consistency with future VMI instances.
// KubeVirt doesn't trigger VMI restart on template metadata changes.
if _, ok := obj.(*virtv1.VirtualMachine); ok {
jp.Append(
patch.NewJSONPatchOperation(patch.PatchReplaceOp, "/spec/template/metadata/labels", metadata.Labels),
patch.NewJSONPatchOperation(patch.PatchReplaceOp, "/spec/template/metadata/annotations", metadata.Annotations),
Comment on lines +148 to +149
Copy link
Member

@yaroslavborbat yaroslavborbat Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use patch.WithTest and patch.WithReplace

example

jp.Append(
    patch.WithTest(/spec/template/metadata/labels", oldLabels),
    patch.WithReplace(/spec/template/metadata/labels", newLabels),
)

)
}

bytes, err := jp.Bytes()
if err != nil {
return err
}

return h.client.Patch(ctx, obj, client.RawPatch(types.JSONPatchType, bytes))
}

Expand Down
Loading