Conversation
There was a problem hiding this comment.
Pull request overview
Updates the dotnet feature’s latest version resolution to use the official .NET releases index metadata instead of lexicographic STS/LTS comparisons.
Changes:
- Resolve
latestfromrelease-metadata/releases-index.jsonby selecting the firstactiveentry. - Install
jqas a dotnet feature dependency and update helpers/tests accordingly. - Remove deprecated
aspireworkload usage from docs and workload tests.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/dotnet/scenarios.json | Drops aspire from workload scenario coverage. |
| test/dotnet/install_dotnet_workloads.sh | Removes assertion for deprecated aspire workload installation. |
| test/dotnet/install_dotnet_specific_release.sh | Adjusts specific-release test expectation for .NET 10.0. |
| test/dotnet/install_dotnet_lts.sh | Stops using helper channel-resolution; fetches LTS expected version directly. |
| test/dotnet/dotnet_helpers.sh | Updates test helper to resolve latest via releases-index.json + jq. |
| src/dotnet/scripts/dotnet-helpers.sh | Updates feature helper to resolve latest via releases-index.json + jq. |
| src/dotnet/install.sh | Adds jq to apt dependencies for releases-index parsing. |
| src/dotnet/README.md | Documents prerelease suffixes and removes aspire from workload example. |
| src/dotnet/NOTES.md | Removes aspire from workload example. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
1307a2e to
b628fe5
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
Change looks fine and tests are looking good. Only question is that could we not just have fixed the incorrect string comparison here, instead of rewriting the installation logic?
To be further reviewed by maintainers.
|
The original version check was also contributed by me, and I was never fully satisfied with its design. I later discovered the releases index, which would have been a more robust solution from the start. Given that this is now the second time the version check has broken, I believe it is an appropriate moment to replace the current approach with something more reliable. The Benefits of using the releases index:
|
Summary
Fix the dotnet feature's
latestresolution so it is resolved from the .NET releases index instead of comparing STS and LTS versions lexicographically.Resolves #1597.
Changes
latestfromrelease-metadata/releases-index.jsonactiveentry from the releases indexlatest-sdkfor SDK installs andlatest-runtimefor runtime installsltsflowing through the vendoreddotnet-install.shlogicjqto the feature install dependenciesValidation
devcontainer features test -p . -f dotnet10.0.103for SDK and10.0.3for runtime