chore: sync II spec to dfinity/internet-identity release-2026-06-15#294
Closed
pr-automation-bot-public[bot] wants to merge 2 commits into
Closed
chore: sync II spec to dfinity/internet-identity release-2026-06-15#294pr-automation-bot-public[bot] wants to merge 2 commits into
pr-automation-bot-public[bot] wants to merge 2 commits into
Conversation
Upstream serves the same internal-page destinations under multiple URL forms (internetcomputer.org/docs/current/... and docs.internetcomputer.org/...), and the two source specs are not migrated in lockstep. The old hardcoded full-URL linkMap silently stopped matching when vc-spec.md switched to the docs subdomain, and the validation regex only knew the path form, so the unrewritten absolute links passed the build. - Normalize the volatile domain/prefix to a canonical path#fragment, then look up a shared PATH_MAP (encodes only the irregular split-doc anchors) - Validation now catches both the internetcomputer.org/docs and docs.internetcomputer.org forms, failing the build on any unmapped link - Generate the adaptation-log comment from the rewrites actually applied
marc0olo
approved these changes
Jun 16, 2026
Member
marc0olo
added a commit
that referenced
this pull request
Jun 16, 2026
Syncs the Internet Identity spec from dfinity/internet-identity release-2026-06-15 (pinned 18130689 → 1f4104b5): regenerates the two reference specs and the internet-identity.did interface (adds SSO credential migration types, DoH email-recovery additions, and message_id correlation). Also hardens the sync script's link rewriting. Upstream serves the same internal-page destinations under multiple URL forms (internetcomputer.org/docs/current/... and docs.internetcomputer.org/...), and the two source specs are not migrated in lockstep. The old hardcoded full-URL map silently stopped matching when vc-spec.md switched to the docs subdomain, and the validation regex only knew the path form, so the unrewritten absolute links would have shipped: - Normalize the volatile domain/prefix to a canonical path#fragment, then look up a shared PATH_MAP (encodes only the irregular split-doc anchors) - Validation now catches both URL forms, failing the build on any unmapped link instead of passing silently - Replace the verbose per-link adaptation log in the generated specs with a concise generated-by / do-not-edit marker plus the Upstream attribution Supersedes #294 (same release, blocked by the bot-PR policy after a human fix commit) and #290 (release-2026-06-05-hotfix; its content is a subset of 06-15).
lwshang
added a commit
that referenced
this pull request
Jun 18, 2026
…295) ## Summary Human-owned replacement for the blocked bot sync PRs. Syncs the Internet Identity spec from `dfinity/internet-identity` `release-2026-06-15` (pinned `18130689` → `1f4104b5`) and hardens the sync script's link handling. **Content:** - Regenerated `docs/references/internet-identity-spec.md` and `docs/references/verifiable-credentials-spec.md` - Updated `public/references/internet-identity.did` (+92 lines): SSO credential migration types, DoH email-recovery additions, `message_id` correlation, typed DoH failure reasons - Bumped `.sources/VERSIONS` and the submodule pin **Script fix (`scripts/sync-ii-spec.mjs`):** Upstream serves the same internal-page destinations under multiple URL forms (`internetcomputer.org/docs/current/...` and `docs.internetcomputer.org/...`), and the two source specs are not migrated in lockstep. The old hardcoded full-URL map silently stopped matching when `vc-spec.md` switched to the docs subdomain, and the validation regex only knew the path form, so the unrewritten absolute links would have shipped. - Normalize the volatile domain/prefix to a canonical `path#fragment`, then look up a shared `PATH_MAP` (encodes only the irregular split-doc anchors that can't be inferred) - Validation now catches both URL forms, failing the build on any unmapped link instead of passing silently - Replace the verbose per-link adaptation log in the generated specs with a concise generated-by / do-not-edit marker plus the `<!-- Upstream: -->` attribution **Reader-facing markdown is unchanged** vs `main`: the spec links render as the same relative internal links as before; only the trailing sync-metadata comments differ. The substantive content change is the `.did` interface. ## Supersedes - #294 — same release; blocked by the bot-PR policy once a human fix commit landed on the bot's branch - #290 — `release-2026-06-05-hotfix`; its spec content is a subset of 06-15 (verified: `ii-spec.mdx` identical, `vc-spec.md` differs only by the link-domain change, `.did` is a superset) ## Verified - `npm run sync:ii-spec` passes all checks; output is idempotent (two consecutive runs are byte-identical) - `npm run build` succeeds - No absolute docs links remain in either output; all rewritten anchors resolve to real headings --------- Co-authored-by: Linwei Shang <linwei.shang@dfinity.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automated sync of the Internet Identity specification from
dfinity/internet-identity.Release:
release-2026-06-15(pinned from1813068→1f4104b5)Changed upstream files:
docs/vc-spec.mdsrc/internet_identity/internet_identity.didRan
npm run sync:ii-spec— regenerateddocs/references/internet-identity-spec.mdanddocs/references/verifiable-credentials-spec.mdBuild passed ✓
Checklist
docs/references/internet-identity-spec.mdfor content changesdocs/references/verifiable-credentials-spec.mdfor content changesinternetcomputer.orglink patterns (script exits non-zero if any were missed)Sync recommendation
sync from dfinity/internet-identity — docs/ii-spec.mdx, docs/vc-spec.md, src/internet_identity/internet_identity.did