chore: sync II spec to release-2026-06-15 with robust link rewriting#295
Open
marc0olo wants to merge 2 commits into
Open
chore: sync II spec to release-2026-06-15 with robust link rewriting#295marc0olo wants to merge 2 commits into
marc0olo wants to merge 2 commits into
Conversation
This was referenced Jun 16, 2026
|
🤖 Preview build failed. |
Syncs the Internet Identity spec from dfinity/internet-identity release-2026-06-15 (pinned 18130689 → 1f4104b5): regenerates the two reference specs and the internet-identity.did interface (adds SSO credential migration types, DoH email-recovery additions, and message_id correlation). Also hardens the sync script's link rewriting. Upstream serves the same internal-page destinations under multiple URL forms (internetcomputer.org/docs/current/... and docs.internetcomputer.org/...), and the two source specs are not migrated in lockstep. The old hardcoded full-URL map silently stopped matching when vc-spec.md switched to the docs subdomain, and the validation regex only knew the path form, so the unrewritten absolute links would have shipped: - Normalize the volatile domain/prefix to a canonical path#fragment, then look up a shared PATH_MAP (encodes only the irregular split-doc anchors) - Validation now catches both URL forms, failing the build on any unmapped link instead of passing silently - Replace the verbose per-link adaptation log in the generated specs with a concise generated-by / do-not-edit marker plus the Upstream attribution Supersedes #294 (same release, blocked by the bot-PR policy after a human fix commit) and #290 (release-2026-06-05-hotfix; its content is a subset of 06-15).
697992a to
a83c59b
Compare
lwshang
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Human-owned replacement for the blocked bot sync PRs. Syncs the Internet Identity spec from
dfinity/internet-identityrelease-2026-06-15(pinned18130689→1f4104b5) and hardens the sync script's link handling.Content:
docs/references/internet-identity-spec.mdanddocs/references/verifiable-credentials-spec.mdpublic/references/internet-identity.did(+92 lines): SSO credential migration types, DoH email-recovery additions,message_idcorrelation, typed DoH failure reasons.sources/VERSIONSand the submodule pinScript fix (
scripts/sync-ii-spec.mjs):Upstream serves the same internal-page destinations under multiple URL forms (
internetcomputer.org/docs/current/...anddocs.internetcomputer.org/...), and the two source specs are not migrated in lockstep. The old hardcoded full-URL map silently stopped matching whenvc-spec.mdswitched to the docs subdomain, and the validation regex only knew the path form, so the unrewritten absolute links would have shipped.path#fragment, then look up a sharedPATH_MAP(encodes only the irregular split-doc anchors that can't be inferred)<!-- Upstream: -->attributionReader-facing markdown is unchanged vs
main: the spec links render as the same relative internal links as before; only the trailing sync-metadata comments differ. The substantive content change is the.didinterface.Supersedes
release-2026-06-05-hotfix; its spec content is a subset of 06-15 (verified:ii-spec.mdxidentical,vc-spec.mddiffers only by the link-domain change,.didis a superset)Verified
npm run sync:ii-specpasses all checks; output is idempotent (two consecutive runs are byte-identical)npm run buildsucceeds