pkg/*: deb: remove --dpkg-shlibdeps-params=--ignore-missing-info override#451
Merged
Merged
Conversation
2 tasks
…ride This override was originally added in [moby@bb66d71] in 2016, which updated the build scripts for building the new `containerd`, `containerd-shim`, `ctr`, and `runc` binaries. Unfortunately, the pull request did not call-out the reason for adding this specific override, but there was a discussion about some distros not having the required GCC version to compile seccomp; > This is currently failing on oracle linux-6 because it can't compile runc > (...) It looks like it is related to this bug: seccomp/libseccomp-golang#2 > which states that the gcc version is too old. Currently, the gcc version > that comes with oracle linux 6 is gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-16) > > ... > > It looks like ubuntu precise has the same gcc issue, it isn't new enough. > Looks like the newest version that is apt is 4.6.3, and I need at least > 4.6.4. The [dpkg-shlibdeps(1)] manpage explicitly calls this option out as discouraged: --ignore-missing-info Do not fail if dependency information can't be found for a shared library (since dpkg 1.14.8). Usage of this option is discouraged, all libraries should provide dependency information (either with shlibs files, or with symbols files) even if they are not yet used by other packages. Since then, this option was copied to all the deb packages we build. Let's remove this option, as it's discouraged, may be hiding real problems (missing dependencies that would otherwise fail the build), and very likely was never needed for most CLI binaries, and likely no longer needed for the dockerd and containerd binaries (the containerd packaging scripts do not even have this option set). [moby@bb66d71]: moby/moby@bb66d71 [dpkg-shlibdeps(1)]: https://manpages.debian.org/trixie/dpkg-dev/dpkg-shlibdeps.1.en.html#ignore Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
rm_legacy_override
branch
from
dc0e87f to
b33471d
Compare
vvoland
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg/*: deb: remove --dpkg-shlibdeps-params=--ignore-missing-info override
This override was originally added in moby@bb66d71 in 2016, which updated
the build scripts for building the new
containerd,containerd-shim,ctr,and
runcbinaries.Unfortunately, the pull request did not call-out the reason for adding this
specific override, but there was a discussion about some distros not having
the required GCC version to compile seccomp;
The dpkg-shlibdeps(1) manpage explicitly calls this option out as discouraged:
Since then, this option was copied to all the deb packages we build.
Let's remove this option, as it's discouraged, may be hiding real problems
(missing dependencies that would otherwise fail the build), and very likely
was never needed for most CLI binaries, and likely no longer needed for the
dockerd and containerd binaries (the containerd packaging scripts do not even
have this option set).