change: Drop support for Node.js 18 and 20 (v14)#3138
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the project's supported Node.js version to 22 and higher, dropping support for versions 18 and 20 in the documentation and package engine requirements. Feedback indicates that the changes are incomplete, as CI configuration files and other package manifests within the repository still need to be updated to reflect this new requirement consistently.
| "homepage": "https://firebase.google.com/", | ||
| "engines": { | ||
| "node": ">=18" | ||
| "node": ">=22" |
There was a problem hiding this comment.
The PR description mentions adding "Node.js 26 to CIs", which appears to be a typo (likely intended for Node.js 22). Additionally, this PR is missing updates to CI configuration files (e.g., GitHub Actions workflows) and other package manifests in the repository (for instance, test/integration/postcheck/package.json still references @types/node: >=14.0.0). Please ensure all references to supported Node.js versions are updated consistently across the project.
2 participants
Drop support for Node.js 18 and 20
Add Node.js 26 to CIs
Upgrade firebase-tools to v15