Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,20 @@ jobs:

strategy:
matrix:
node-version: [18.x, 20.x, 22.x, 24.x]
node-version: [22.x, 24.x, 26.x]

steps:
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
- name: Set up Node.js ${{ matrix.node-version }}
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: ${{ matrix.node-version }}
# Java 21 is required by firebase-tools to run emulator-based integration tests
- name: Set up Java
uses: actions/setup-java@99b8673ff64fbf99d8d325f52d9a5bdedb8483e9 # v4.2.1
with:
distribution: 'temurin'
java-version: '21'
- name: Install and build
run: |
npm ci
Expand All @@ -28,6 +34,6 @@ jobs:
run: npm run api-extractor
- name: Run emulator-based integration tests
run: |
npm install -g firebase-tools@11.30.0
npm install -g firebase-tools@15.17.0
firebase emulators:exec --project fake-project-id --only auth,database,firestore \
'npx mocha test/integration/auth.spec.ts test/integration/database.spec.ts test/integration/firestore.spec.ts --slow 5000 --timeout 20000 --require ts-node/register'
11 changes: 9 additions & 2 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,14 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: 18.x
node-version: 22.x

# Java 21 is required by firebase-tools to run emulator-based integration tests
- name: Set up Java
uses: actions/setup-java@99b8673ff64fbf99d8d325f52d9a5bdedb8483e9 # v4.2.1
with:
distribution: 'temurin'
java-version: '21'

- name: Install and build
run: |
Expand All @@ -52,7 +59,7 @@ jobs:

- name: Run emulator-based integration tests
run: |
npm install -g firebase-tools@11.30.0
npm install -g firebase-tools@15.17.0
firebase emulators:exec --project fake-project-id --only auth,database,firestore \
'npx mocha test/integration/auth.spec.ts test/integration/database.spec.ts test/integration/firestore.spec.ts --slow 5000 --timeout 20000 --require ts-node/register'

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: 18.x
node-version: 22.x

- name: Install and build
run: |
Expand Down Expand Up @@ -122,7 +122,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: 18.x
node-version: 22.x

- name: Publish preflight check
id: preflight
Expand Down
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,7 @@ requests, code review feedback, and also pull requests.

## Supported Environments

We currently support Node.js 18 and higher, but support for Node.js 18 and Node.js 20 is deprecated. We strongly encourage
you to use Node.js 22 or higher as we will drop support for Node.js 18 and Node.js 20 in the next major version.
We currently support Node.js 22 and higher.

Please also note that the Admin SDK should only
be used in server-side/back-end environments controlled by the app developer.
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"license": "Apache-2.0",
"homepage": "https://firebase.google.com/",
"engines": {
"node": ">=18"
"node": ">=22"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The PR description mentions adding "Node.js 26 to CIs", which appears to be a typo (likely intended for Node.js 22). Additionally, this PR is missing updates to CI configuration files (e.g., GitHub Actions workflows) and other package manifests in the repository (for instance, test/integration/postcheck/package.json still references @types/node: >=14.0.0). Please ensure all references to supported Node.js versions are updated consistently across the project.

},
"scripts": {
"build": "gulp build",
Expand Down
Loading