[BUGFIX] Simplify environment variable check for GEMPY_FLAT_STACKS evaluation#56
Open
[BUGFIX] Simplify environment variable check for GEMPY_FLAT_STACKS evaluation#56
Conversation
…onstraints - Introduced `allowed_partners` to restrict pairwise constraint injection based on geological relations. - Added `_build_allowed_partners` to compute partner sets using `surface_to_stack` and `faults_relations`. - Updated `find_and_inject_multi_surface_constraints_multicore` to leverage filtered partners for efficiency
- Updated `_average_overlapping_vertices` to handle fault-layer overlaps by copying unperturbed fault vertices to destination layers. - Refined logic to exclude fault-layer pairs during averaging and QEF constraint injection for improved fault plane smoothness. - Enhanced tests to verify vertex consistency, excluding fault-destination cases.
- Documented the Quadratic Error Function (QEF) system for standard and multi-surface constraints. - Included explanations for weighted QEF handling of faults and watertight mesh generation. - Detailed overlap resolution logic, mesh modifications, and fault
- Allowed QEF constraints for fault-related pairs by removing their exclusion during partner filtering. - Improved handling of overlapping pairs to support fault-aware watertight mesh generation.
- Updated `_average_overlapping_vertices` to handle specific cases: same-stack exclusion, fault→layer direct copying, and erosion/onlap pair averaging. - Improved overlap resolution by clarifying fault and same-stack interaction rules. - Enhanced logic for vertex averaging to ensure watertight meshes in multi-surface overlap scenarios.
- Updated fault handling in overlap resolution to exclude fault-fault pairs from QEF injection and triangle sharing. - Refined partner filtering logic using stack relations to improve fault-aware constraint application. - Enhanced support for independent fault stacks in dual contouring workflows.
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

[BUGFIX] Simplify environment variable check for GEMPY_FLAT_STACKS evaluation
[ENH] Add fault-aware partner filtering for dual contouring surface constraints
allowed_partnersto restrict pairwise constraint injection based on geological relations._build_allowed_partnersto compute partner sets usingsurface_to_stackandfaults_relations.find_and_inject_multi_surface_constraints_multicoreto leverage filtered partners for efficiency[ENH] Improve fault-layer overlap handling in dual contouring workflow
_average_overlapping_verticesto handle fault-layer overlaps by copying unperturbed fault vertices to destination layers.[ENH] Add QEF system documentation for dual contouring
[ENH] Remove fault-pair exclusion logic in QEF setup
[ENH] Refine vertex sharing logic for overlap watertightness
_average_overlapping_verticesto handle specific cases: same-stack exclusion, fault→layer direct copying, and erosion/onlap pair averaging.[ENH] Exclude fault-fault pairs and refine partner filtering logic