perf(core): [SDK Overhead Reduction 7] Lazily allocate Breadcrumb data#5598
Draft
adinauer wants to merge 1 commit into
Draft
perf(core): [SDK Overhead Reduction 7] Lazily allocate Breadcrumb data#5598adinauer wants to merge 1 commit into
adinauer wants to merge 1 commit into
Conversation
Avoid allocating a ConcurrentHashMap for breadcrumbs that never set data. Initialize the data map on first write while preserving concurrent writes with double-checked locking. Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Jun 23, 2026
Merged
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (SDK Overhead Reduction)
📜 Description
Lazily allocates the
Breadcrumbdata map instead of creating aConcurrentHashMapfor every breadcrumb.Plain breadcrumbs that only set message, category, type, or level now keep a shared empty map. The data map is initialized on first
setDatacall with double-checked locking and remains aConcurrentHashMapafter initialization.💡 Motivation and Context
Most breadcrumbs do not attach data, but each breadcrumb previously allocated an empty
ConcurrentHashMap. This reduces allocation overhead for the common plain breadcrumb path while preserving concurrent first-write behavior.💚 How did you test it?
./gradlew :sentry:test --tests io.sentry.BreadcrumbTest./gradlew spotlessApply apiDump📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
#skip-changelog