perf(core): [SDK Overhead Reduction 9] Lazily allocate reflection serializer state#5600
Draft
adinauer wants to merge 1 commit into
Draft
Conversation
Defer creation of the reflection serializer visiting set until reflection serialization is actually needed. Normal SDK payload serialization uses explicit serializers, so this avoids an unused HashSet allocation for each writer.
This was referenced Jun 23, 2026
Merged
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (SDK Overhead Reduction)
📜 Description
Lazily creates the
JsonReflectionObjectSerializervisiting set only when reflection serialization is used.The set still tracks objects during reflection serialization for cyclic reference and max-depth handling, but normal JSON serialization paths no longer allocate it eagerly.
💡 Motivation and Context
Most SDK payloads serialize through explicit
JsonSerializableimplementations or other supported direct types. Those paths do not need reflection cycle tracking, so allocating an emptyHashSetfor every reflection serializer adds unnecessary overhead.💚 How did you test it?
./gradlew :sentry:test --tests io.sentry.JsonReflectionObjectSerializerTest --tests io.sentry.JsonObjectSerializerTest./gradlew spotlessApply apiDump./gradlew :sentry:test --tests io.sentry.JsonReflectionObjectSerializerTest --tests io.sentry.JsonObjectSerializerTest📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
#skip-changelog